Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Some words on the dictionary and the core's code doesn't exists or are misspelled.
Proposed resolution
Fix or ignore the following list of words on the code and remove them from the dictionary:
- anotherwordenglish > fix
- anotherwordgerman > fix
- asdrsad > ignore
- barmm > ignore
- foomm > ignore
- hilfetestmodul > ignore
- nonwordgerman > fix
- nonworditem > fix
- notawordenglish > fix
- notawordgerman > fix
- sdeeeee > ignore
- sqruct > ignore
- wcsrefsdf > ignore
- übersetzung > ignore
Remaining tasks
Do a reroll; update the IS. Review
Comment | File | Size | Author |
---|---|---|---|
#33 | reroll_diff_31-33.txt | 2.3 KB | ravi.shankar |
#33 | 3164699-33.patch | 11.22 KB | ravi.shankar |
| |||
#31 | 3164699-31.patch | 11.23 KB | WagnerMelo |
#29 | reroll_diff_3164699_26-29.txt | 2.53 KB | ankithashetty |
#29 | 3164699-29.patch | 11.18 KB | ankithashetty |
Comments
Comment #2
jungleComment #3
jungleThe first iteration.
Comment #4
jungleComment #5
jungleOver 80 chars. Addressing.
Comment #6
quietone CreditAttribution: quietone as a volunteer commentedComment #7
kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commentedre-roll the patch.
Comment #8
KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Association, Drupal Care commentedComment #10
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedRerolled patch .Please check this
Comment #11
jungleRerolled and made some changes.
Comment #12
jungleRemoving übersetzung further.
After:
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedIf nonworditem becomes non-word-item why doesn't nonwordgerman follow the same pattern and bceome non-word-german?
Comment #14
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedMade changes as per comment #13, please review.
Comment #15
sulfikar_s CreditAttribution: sulfikar_s at Zyxware Technologies commentedUpdated some more changes as per our problem requirements. Also attaching the interdiff.
Please review!
Comment #16
quietone CreditAttribution: quietone as a volunteer commentedOn a brief look the latest patch look good.
Reading the IS, all of the words identified by jungle are not yet removed from the dictionary and added as needed to the cspell ignore lines. Let's make sure all of them are moved to cspell ignore lines and removed from the dictionary in this patch and check if there are any others.
Comment #17
quietone CreditAttribution: quietone as a volunteer commentedComment #18
paulocsI'll work on it.
Comment #19
paulocsAdded "sdeeeee" to the patch.
I was not able to create an interdiff because patch #15 needed a re-roll.
Comment #20
quietone CreditAttribution: quietone as a volunteer commented@paulocs, thanks for the patch. When the interdiff fails, make a diff, see Creating an interdiff-#What about rerolled patches?
I must be missing something about these Help topic tests.
wcsrefsdf is used in \Drupal\Tests\help_topics\Functional\HelpTopicSearchTest::testHelpSearch. I don't understand why this is using the string 'wcsrefsdf'. It appears to be an title in English so why not use a correctly spelled English word.
$session->linkExists('Foo in English title wcsrefsdf');
Comment #23
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented#12 #15 and #19 not applying in durpal-9.3.x-dev
Needs to re-roll
error: patch failed: core/misc/cspell/dictionary.txt:44
error: core/misc/cspell/dictionary.txt: patch does not apply
Checking patch core/modules/help_topics/tests/modules/help_topics_test/help_topics/help_topics_test.test.html.twig...
Checking patch core/modules/help_topics/tests/modules/help_topics_test/src/Plugin/HelpSection/TestHelpSection.php...
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php...
error: while searching for:
// All of the above tests used the TestHelpSection plugin. Also verify
// that we can search for translated regular help topics, in both English
// and German.
$this->drupalPostForm('search/help', ['keys' => 'nonworditem'], 'Search');
$this->assertSearchResultsCount(1);
$session->linkExists('ABC Help Test module');
// Click the link and verify we ended up on the topic page.
$this->clickLink('ABC Help Test module');
$session->pageTextContains('This is a test');
$this->drupalPostForm('search/help', ['keys' => 'nonwordgerman'], 'Search', [
'language' => $german,
]);
$this->assertSearchResultsCount(1);
error: patch failed: core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php:136
error: core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php: patch does not apply
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php...
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicTranslationTest.php...
Comment #24
quietone CreditAttribution: quietone at PreviousNext commented@vikashsoni, I think you forgot to set this to Needs Work. Thank you for your interest. Posting details of a patch not failing is not necessary and adds noise to the issue. If you haven't already read it the contributor guide on Drupal.org has information about how to contribute, particularly the process to Review a patch or merge request. There are also clear guidelines for How is credit granted for Drupal core issues. Thanks
Setting to NW and adding reroll tag. Also when the patch is updated, the list of words in the IS needs to be updated as well.
When rerolling following the instructions for working with cspell. there is a link to the instructions in the Issue Summary of the parent issue, #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them. Thanks
Comment #25
andregp CreditAttribution: andregp at CI&T commentedJust updating the IS formatting.
I'l work on a reroll.
Comment #26
andregp CreditAttribution: andregp at CI&T commentedMade the reroll, also changed the words: anotherwordenglish anotherwordgerman nonwordgerman nonworditem notawordenglish notawordgerman to use hiphens just to keep consistency (inspired on comment #13).
Here is the patch and a diff.
Comment #27
andregp CreditAttribution: andregp at CI&T commentedComment #28
jungleThanks @andregp. Tests did not pass in #26.
Comment #29
ankithashettyRerolled the patch in #26, thanks!
Comment #31
WagnerMelo CreditAttribution: WagnerMelo at CI&T commentedHello, i rerolled the patch #29, and its needs review.
Comment #32
longwaveThis looks OK to me.
Comment #33
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedAdded a reroll of patch #31 for Drupal 10.0.x.
Comment #34
alexpottCommitted a28c9b3 and pushed to 10.0.x. Thanks!
Committed and pushed 60d6c151a9 to 9.5.x and 1301a82faf to 9.4.x. Thanks!
Backported to 9.4.x as the changes are to tests.