We just updated the PHP version on a site and the logs are filling up with strpos() notices:

Deprecated function: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in advagg_mod_js_move_to_footer() in advagg/advagg_mod/advagg_mod.module.

Attaching a patch to correct this.

CommentFileSizeAuthor
#2 advagg-strpos_notices-3161790-2-7.patch1.29 KBmicnap

Comments

micnap created an issue. See original summary.

micnap’s picture

micnap commented
StatusFileSize
new advagg-strpos_notices-3161790-2-7.patch1.29 KB
idebr’s picture

idebr commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Component: Code » Modifier
Status: Needs review » Reviewed & tested by the community

This seems reasonable, probably doesn't need to cast it too but doesn't hurt.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks @all!

  • thalles committed 2fbed24 on 7.x-2.x authored by micnap 
    Issue #3161790 by micnap: strpos notices for PHP 7.3
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.