Image support for Paragraphs & Media

As paragraphs are parts of a single page for a SEO sitemap you would not want to index the paragraph itself and you should be fine with indexing the actual webpage.

Images/pdfs could profit somewhat from being explicitely indexed in a sitemap, but there is no built in support for images inside of media or paragraphs yet. For media you might want to look at #2987748: Add Media images to sitemap.

However IMO if you are indexing the page the images/pdf's are at, google will pick those up.

+++ b/src/Plugin/simple_sitemap/UrlGenerator/EntityUrlGeneratorBase.php
@@ -2,6 +2,8 @@
 namespace Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator;

@@ -222,22 +224,72 @@ abstract class EntityUrlGeneratorBase extends UrlGeneratorBase {
+  protected function getDataFromParagraphField(array &$image_data, ContentEntityBase $entity, FieldConfigBase $field) {
+    foreach ($entity->get($field->getName())->getValue() as $paragraph) {
+      $paragraph_entity = Paragraph::load($paragraph['target_id']);
+
+      // Check if paragraph was loaded.
+      if (empty($paragraph_entity)) {

use foreach ($entity->get($field->getName() as $item) and then $item->entity, no need to hardcode paragraphs.

I wouldn't pass in $field though but just the field name. The type hint is wrong anyway, this would fail hard if it's a base field.

That said, it might be better to optionally support the entity_usage project, you could just ask its APi to get all references of a certain type. Then you'd also support media entities for example.

4.x patch

A fresh look at the issue.

Main points:

• Images are searched by mime type. This allows us to not be limited to a specific field type.
• The paragraph entity is checked by the ParagraphInterface, not by the field type. This works even if the "paragraphs" module is not enabled or if it's missing from the codebase (because that's how PHP works).
• A similar check can be used for media entities.

@gbyte Your opinion is important here (as the module creator).

Reupload Patch for simple_sitemap version 4.1.2

First, thanks all for the patch, I have been evaluating it and seems to work as advertised.

I had to reroll it so I am attaching the re-roll which should apply cleanly against 4.x.

De-assigning assuming this is no longer being worked by gbyte :)

@ManuelGarcia @WalkingDexter So sorry, this slipped my mind. Will make a todo and look at it in October! Anyone feel free to look at the code and add your opinions!

@WalkingDexter This is really neat, sorry I missed your contribution.

@WalkingDexter I commited last night without giving you author attribution - is there a way to fix that?

@gbyte I don't think this is possible since the commit is already done. Don't worry, my contribution is already listed in the Git message.