Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review using the coder module. Attached you will find a patch for the problems found by the Coding and Commenting standards reviews.

Note, there were also three warnings thrown by the "interface text translatability" review which is provided by the potx module. None of these are fixed in the attached patch. For all three of the warnings, fivestar is using t() on a dynamic variable which is not what that function was designed for. You should consider using the tt() function provided by the i18nstrings module instead.

fivestar.module:
  Line 1520: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.

  Line 1525: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.

fivestar_color.inc
  Line 205: The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there.

Cheers,
Stella

CommentFileSizeAuthor
fivestar_style.patch16.05 KBstella
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stella’s picture

Title: Patches for Coder Review fixes » Patch for coding and commenting styling issues
catch’s picture

Status: Needs review » Reviewed & tested by the community

These are all whitespace spaces and some capitalisation, patch applies cleanly, so rtbc.

quicksketch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks catch! If possible, could you submit D5 patches also? This one mostly applied but needed a little tweaking. Ported and committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.