Following issues needs to be done to make it drupal 9 ready

------ ---------------------------------------------------------------------
Line login_history.module
------ ---------------------------------------------------------------------
35 Call to deprecated function db_insert():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container
and
call insert() on it. For example,
63 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the
container
and call query() on it. For example,
------ ---------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/Controller/LoginHistoryController.php
------ ---------------------------------------------------------------------
61 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container
and
call select() on it. For example,
107 Call to deprecated method getUsername() of class
Drupal\user\Entity\User:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Session\AccountInterface::getAccountName() or
\Drupal\user\UserInterface::getDisplayName() instead.
------ ---------------------------------------------------------------------

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Saurabh_sgh created an issue. See original summary.

saurabh-2k17’s picture

I think this patch will make it ready for D9.

Thanks

saurabh-2k17’s picture

Assigned: saurabh-2k17 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3138851-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

saurabh-2k17’s picture

FileSize
1.97 KB

Updated the patch as last one failed

saurabh-2k17’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 3138851-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shimpy’s picture

Status: Needs work » Needs review
FileSize
2.24 KB

Attaching Patch for deprecated functions

shimpy’s picture

Ignore patch #8

Status: Needs review » Needs work

The last submitted patch, 9: 3138851_9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shimpy’s picture

Status: Needs work » Needs review
FileSize
2.24 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3138851_10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ridhimaabrol24’s picture

Assigned: Unassigned » ridhimaabrol24
ridhimaabrol24’s picture

Assigned: ridhimaabrol24 » Unassigned
Status: Needs work » Needs review
FileSize
2.6 KB

Fixing the failed test.

Status: Needs review » Needs work

The last submitted patch, 14: 3138851_14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ridhimaabrol24’s picture

greggles’s picture

Status: Needs work » Closed (duplicate)

There's an existing issue at #3042861: Drupal 9 Deprecated Code Report for Login History module to upgrade the module. Perhaps interested folks could help with that?