PHPCS reported the following issues for Drupal standards.

FILE: entity_export_csv/css/admin.css
------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------
  8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: entity_export_csv/css/entity_export_csv.css
------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
------------------------------------------------------------------------
  5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
  7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: entity_export_csv/config/schema/entity_export_csv.schema.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 72 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: entity_export_csv/entity_export_csv.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: entity_export_csv/src/Form/EntityExportCsvSettings.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 1 WARNING AFFECTING 16 LINES
-------------------------------------------------------------------------------------------------------------------------------------
   6 | WARNING | [x] Unused use statement
 115 | ERROR   | [x] Concat operator must be surrounded by a single space
 127 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 142 | ERROR   | [x] Concat operator must be surrounded by a single space
 155 | ERROR   | [x] Concat operator must be surrounded by a single space
 163 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 226 | ERROR   | [ ] Missing parameter comment
 228 | ERROR   | [ ] Type hint "array" missing for $values
 249 | ERROR   | [ ] Missing parameter comment
 250 | ERROR   | [ ] Missing parameter comment
 252 | ERROR   | [ ] Description for the @return value is missing
 263 | ERROR   | [ ] Missing parameter comment
 263 | ERROR   | [ ] Missing parameter type
 264 | ERROR   | [ ] Missing parameter comment
 265 | ERROR   | [ ] Missing parameter comment
 267 | ERROR   | [ ] Description for the @return value is missing
 301 | ERROR   | [ ] Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Form/EntityExportCsv.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 28 ERRORS AND 2 WARNINGS AFFECTING 29 LINES
-------------------------------------------------------------------------------------------------------------------------------------
  14 | WARNING | [x] Unused use statement
  25 | ERROR   | [ ] Missing short description in doc comment
  30 | ERROR   | [ ] Missing short description in doc comment
  35 | ERROR   | [ ] Missing short description in doc comment
 113 | ERROR   | [x] Space before opening parenthesis of function call prohibited
 161 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 240 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 247 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 254 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 280 | ERROR   | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
 382 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 390 | ERROR   | [x] Missing function doc comment
 399 | ERROR   | [ ] Missing parameter comment
 412 | ERROR   | [ ] Missing parameter comment
 413 | ERROR   | [ ] Missing parameter comment
 415 | ERROR   | [ ] Description for the @return value is missing
 424 | ERROR   | [ ] Missing parameter comment
 425 | ERROR   | [ ] Missing parameter comment
 427 | ERROR   | [ ] Description for the @return value is missing
 436 | ERROR   | [ ] Missing parameter comment
 437 | ERROR   | [ ] Missing parameter comment
 439 | ERROR   | [ ] Description for the @return value is missing
 450 | ERROR   | [ ] Missing parameter comment
 451 | ERROR   | [ ] Missing parameter comment
 453 | ERROR   | [ ] Description for the @return value is missing
 472 | ERROR   | [ ] Missing parameter comment
 472 | ERROR   | [ ] Missing parameter type
 473 | ERROR   | [ ] Missing parameter comment
 474 | ERROR   | [ ] Missing parameter comment
 476 | ERROR   | [ ] Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/EntityExportCsvManager.php
-------------------------------------------------------------------------
FOUND 4 ERRORS AND 12 WARNINGS AFFECTING 15 LINES
-------------------------------------------------------------------------
   6 | WARNING | [x] Unused use statement
   7 | WARNING | [x] Unused use statement
   9 | WARNING | [x] Unused use statement
  10 | WARNING | [x] Unused use statement
  19 | WARNING | [x] Unused use statement
  22 | WARNING | [x] Unused use statement
  23 | WARNING | [x] Unused use statement
  24 | WARNING | [x] Unused use statement
  25 | WARNING | [x] Unused use statement
  26 | WARNING | [x] Unused use statement
  27 | WARNING | [x] Unused use statement
  30 | WARNING | [x] Unused use statement
 282 | ERROR   | [x] There should be no white space before a closing ")"
 295 | ERROR   | [ ] Description for the @return value is missing
 310 | ERROR   | [x] Expected 1 space after FUNCTION keyword; 0 found
 310 | ERROR   | [x] Expected 1 space after USE keyword; found 0
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExportInterface.php
---------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------
  30 | ERROR | [x] Expected 1 blank line before function; 2 found
  76 | ERROR | [ ] Type hint "\Drupal\Core\Field\FieldDefinitionInterface" missing for $field_definition
  76 | ERROR | [ ] Type hint "array" missing for $options
 104 | ERROR | [ ] Type hint "array" missing for $options
 154 | ERROR | [ ] Type hint "\Drupal\Core\Field\FieldDefinitionInterface" missing for $field_definition
 154 | ERROR | [ ] Type hint "array" missing for $options
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExportManagerInterface.php
----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
 35 | ERROR | [x] Expected 1 blank line after function; 0 found
 36 | ERROR | [x] The closing brace for the interface must have an empty line before it
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExportManager.php
-----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------
  56 | ERROR | [x] There should be no white space before a closing ")"
 105 | ERROR | [ ] Type hint "array" missing for $definitions
 106 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/LinkExport.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 42 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/GeolocationExport.php
--------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------
 51 | WARNING | [ ] Possible useless method overriding detected
 53 | ERROR   | [x] Expected 1 blank line after function; 2 found
 56 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/DateRangeExport.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  63 | ERROR | [x] Concat operator must be surrounded by a single space
 125 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/DateTimeExport.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  63 | ERROR | [x] Concat operator must be surrounded by a single space
 119 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/AddressExport.php
----------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------
  6 | WARNING | [x] Unused use statement
 43 | WARNING | [ ] Possible useless method overriding detected
 61 | ERROR   | [x] Doc comment short description must end with a full stop
 63 | ERROR   | [ ] Missing parameter type
 65 | ERROR   | [ ] Missing parameter type
 67 | ERROR   | [ ] Missing parameter type
 70 | ERROR   | [ ] Description for the @return value is missing
 76 | ERROR   | [x] There should be no white space after an opening "["
 76 | ERROR   | [x] There should be no white space before a closing "]"
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExport/TimestampExport.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  51 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
  63 | ERROR | [x] Concat operator must be surrounded by a single space
 102 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Plugin/FieldTypeExportBase.php
---------------------------------------------------------------------------------
FOUND 14 ERRORS AND 3 WARNINGS AFFECTING 14 LINES
---------------------------------------------------------------------------------
  13 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  26 | WARNING | [x] Unused use statement
 198 | ERROR   | [x] Concat operator must be surrounded by a single space
 220 | ERROR   | [x] Whitespace found before first semicolon of FOR loop
 220 | ERROR   | [x] Space found before semicolon; expected "2;" but found "2 ;"
 220 | ERROR   | [x] Whitespace found before second semicolon of FOR loop
 220 | ERROR   | [x] Space found before semicolon; expected "1;" but found "1 ;"
 241 | ERROR   | [x] Concat operator must be surrounded by a single space
 353 | ERROR   | [x] Expected 1 space after FOR keyword; 0 found
 475 | ERROR   | [x] Expected 1 space after FOR keyword; 0 found
 524 | ERROR   | [x] Expected 1 blank line after function; 2 found
 530 | ERROR   | [ ] Missing parameter type
 609 | ERROR   | [x] Expected 1 blank line after function; 2 found
 615 | ERROR   | [ ] Description for the @return value is missing
 625 | ERROR   | [x] Expected 1 blank line after function; 2 found
 631 | ERROR   | [ ] Description for the @return value is missing
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------


FILE: entity_export_csv/src/Annotation/FieldTypeExport.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 37 | ERROR | [x] Expected "int" but found "integer" for @var tag in member variable comment
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Controller/EntityExportCsvDownload.php
--------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
--------------------------------------------------------------------------------------------------------------------
  19 | ERROR   | [x] Whitespace found at end of line
  20 | ERROR   | [ ] Missing short description in doc comment
  28 | ERROR   | [ ] Missing parameter comment
  38 | ERROR   | [x] Space before opening parenthesis of function call prohibited
  60 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
  70 | WARNING | [x] A comma should follow the last multiline array item. Found: $download_url
  75 | WARNING | [x] A comma should follow the last multiline array item. Found: 'entity_content_csv/auto-download'
  76 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
  77 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 104 | ERROR   | [ ] Description for the @return value is missing
 117 | ERROR   | [x] Space after closing parenthesis of function call prohibited
 118 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 3
 118 | ERROR   | [x] Space found before semicolon; expected ");" but found ")\n   ;"
 124 | ERROR   | [ ] Description for the @return value is missing
 128 | ERROR   | [x] Expected 1 blank line after function; 0 found
 129 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/EntityExportCsvManagerInterface.php
---------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------
  69 | ERROR | [x] Doc comment short description must end with a full stop
  71 | ERROR | [ ] Missing parameter type
  73 | ERROR | [ ] Missing parameter type
  84 | ERROR | [x] Doc comment short description must end with a full stop
  99 | ERROR | [x] Doc comment short description must end with a full stop
 119 | ERROR | [ ] Type hint "array" missing for $fields
 119 | ERROR | [ ] Type hint "array" missing for $default_values
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: entity_export_csv/src/EntityExportCsvBatch.php
---------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 6 WARNINGS AFFECTING 20 LINES
---------------------------------------------------------------------------------------
   6 | WARNING | [x] Unused use statement
   9 | WARNING | [x] Unused use statement
  12 | WARNING | [x] Unused use statement
  13 | WARNING | [x] Unused use statement
  14 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  25 | ERROR   | [ ] Missing parameter type
  27 | ERROR   | [ ] Missing parameter type
 196 | ERROR   | [ ] Missing parameter type
 198 | ERROR   | [ ] Missing parameter type
 200 | ERROR   | [ ] Missing parameter type
 203 | ERROR   | [x] Additional blank lines found at end of doc comment
 214 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 215 | ERROR   | [x] Array closing indentation error, expected 6 spaces but found 8
 228 | ERROR   | [ ] Missing parameter type
 230 | ERROR   | [ ] Missing parameter type
 237 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
 239 | ERROR   | [ ] Type hint "array" missing for $context
 277 | ERROR   | [x] Expected 1 blank line after function; 0 found
 278 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Event/EntityExportCsvEvents.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
 12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 22 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------


FILE: entity_export_csv/src/Event/EntityExportCsvFieldsEvent.php
---------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------
  14 | ERROR | [x] Additional blank lines found at end of doc comment
  29 | ERROR | [ ] Class property $entity_type_id should use lowerCamel naming without underscores
  57 | ERROR | [ ] Type hint "array" missing for $fields
  97 | ERROR | [x] Return type must not contain variable name "$fields"
 112 | ERROR | [ ] Type hint "array" missing for $fields
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#2 3138820-2.patch41.19 KBSuresh Prabhu Parkala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gaurav_drupal created an issue. See original summary.

Suresh Prabhu Parkala’s picture

Status: Needs work » Needs review
FileSize
41.19 KB

Please review!

flocondetoile’s picture

Status: Needs review » Closed (outdated)