Remove completely unused 'database_ready' install state logic [#3135310]

Problem/Motivation

$install_state['database_ready'] added some logic around $install_state['database_ready'] but it's never set to TRUE to it's just confusing.

Proposed resolution

Remove logic dependent on $install_state['database_ready'] being true because it never is.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

Comment	File	Size	Author
#2	3135310-2.patch	1.72 KB	alexpott
#2	9.1.x: PHP 7.4 & MySQL 5.7 27,308 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 May 2020 at 23:19

alexpott created an issue. See original summary.

Comment #2

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 10 May 2020 at 23:20

Status:

Active

» Needs review

File	Size
3135310-2.patch	1.72 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,308 pass

Comment #3

longwave

he/him

English

CreditAttribution: longwave at Full Fat Things commented 11 May 2020 at 16:28

Status:

Needs review

» Reviewed & tested by the community

So this was added back in #2352081: Prevent installation over an already installed database but it has never worked - database_ready was always FALSE then and nothing has changed since. Tests pass so this is obviously dead code and can be removed.

Comment #4

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 22 May 2020 at 04:39

Confirmed it never gets set anywhere:

[mandelbrot:maintainer | Thu 23:45:36] $ grep -r "database_ready" *
core/includes/install.core.inc:    'database_ready' => FALSE,
core/includes/install.core.inc:  if ($install_state['database_verified'] && $install_state['database_ready']) {
core/includes/install.core.inc:    // install_verify_database_ready() will throw an AlreadyInstalledException
core/includes/install.core.inc:    install_verify_database_ready();
core/includes/install.core.inc:    'install_verify_database_ready' => [
core/includes/install.core.inc:      'run' => $install_state['database_ready'] ? INSTALL_TASK_SKIP : INSTALL_TASK_RUN_IF_NOT_COMPLETED,
core/includes/install.core.inc:function install_verify_database_ready() {

I wonder what this means for the install_verify_database_ready() task that #3120731: Incorrect "Drupal already installed" if any database settings are wrong or unsatisfactory also added a task to... maybe that's related to why that functionality went wrong in the first place?

Comment #5

22 May 2020 at 04:42

xjm committed c020473 on 9.1.x

Issue #3135310 by alexpott: Remove completely unused 'database_ready'...

Comment #6

22 May 2020 at 04:47

xjm committed 12dc32d on 9.0.x

Issue #3135310 by alexpott: Remove completely unused 'database_ready'...

Comment #7

22 May 2020 at 04:48

xjm committed 70e87a9 on 8.9.x

Issue #3135310 by alexpott: Remove completely unused 'database_ready'...

Comment #8

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 22 May 2020 at 04:51

Version:	9.1.x-dev	» 8.9.x-dev
Status:	Reviewed & tested by the community	» Fixed

Committed to 9.1.x, and cherry-picked to 9.0.x and 8.9.x. I didn't cherry-pick it to 8.8.x because the other installer change wasn't.

@longwave was incorrectly not credited in the commit message (sorry) due to crossposting with myself, but I've fixed this in the issue credits themselves.

Thanks!