Drupal 9 deprecated code report

I would probably combine #3133661: Drupal 9 readiness and this issue together because the former shouldn't be committed until this module is Drupal 9 ready.

1. +++ b/src/AdvancedHelpManager.php
   @@ -133,7 +134,7 @@ class AdvancedHelpManager extends DefaultPluginManager {
   +          $files = FileSystemInterface::scanDirectory("./$module_path",
   

   This will fail because you are trying to use an interface like a class.

   Instead, we should add the file_system service as a dependency for AdvancedHelpManager, and then we can typehint FileSystemInterface in the __construct method, and assign it to a protected class variable.

2. +++ b/src/Plugin/Search/AdvancedHelpSearch.php
   @@ -215,7 +216,7 @@ class AdvancedHelpSearch extends SearchPluginBase implements AccessibleInterface
   +        SearchIndex::index($this->getPluginId(), $info['sid'], $language, file_get_contents($file));
   
   @@ -232,14 +233,14 @@ class AdvancedHelpSearch extends SearchPluginBase implements AccessibleInterface
   +    SearchIndex::clear($this->getPluginId());
   ...
   +    SearchIndex::markForReindex($this->getPluginId());
   

   This will fail because the SearchIndex class does not have static methods index, clear, or markForReindex. These are public methods that require an instance of the class to use.

   Similarly, we can add the search.index service as a dependency, and inject it in the __construct method, and then assign it to a protected class variable.

I maintain freelinking, which depends on advanced_help and advanced_help_hint as test dependencies so at the moment my tests are failing in Drupal 9 without at least the patch in #3133661: Drupal 9 readiness.

Changes asked in #3, has been addressed in the uploaded patch.
Thanks!!

please review the patch!!

Thanks all for the work on this.

I checked this and as soon as we commit this the module will stop working on Drupal 8.7.x which is not something that we want.

At least until Drupal 8.9/Drupal 9 be out we still want to support 8.7.x, so we need to add code for this, here how we can do it:

Preparing Drupal.org projects for Drupal 9

Ok, I worked on this today.

First of all, @jyotimishra123, @mo_farhaz , next time please TEST your changes before to uploading them.

I tested #9 and the file_system service wasn't even being injected and therefore it was triggering an error as soon as the user visits the advanced help page.

The same happened at #2, the changes aren't working at all.

The Drupal 9 Porting Weekend was created indeed to help Drupal to move forward but the event was also a big opportunity to learn and be mentored,

In case of doubt, you can ask for help, In Slack, IRC, or even here, I will be super happy to help but uploading things that are broken is a bit inconsiderate with the person that is going to review your changes.

Next time if I can help let me know :-)

====

Ok, new patch, I injected the file_system service added code to keep this module compatible with Drupal 8.7 and lower. I had to do a trick to inject the search.index service because it does not exists in drupal 8.7 and lower, I got the idea from this post.

Patch attached.