DBTNG: Convert bootstrap.inc

This is all sound.

Just one little thing:

     $result = db_query('SELECT * FROM {variable}');
-    while ($variable = db_fetch_object($result)) {
+    foreach ($result as $variable) {
       $variables[$variable->name] = unserialize($variable->value);
     }

This could become:

$variables = array_map('unserialize', db_query('SELECT name, variable FROM {variable}')->fetchAllKeyed());

array_map() looks *much* more legible. +1!

array_map() is more effective.

 function variable_del($name) {
   global $conf;
 
-  db_query("DELETE FROM {variable} WHERE name = '%s'", $name);
+  db_delete('variable')
+    ->condition('name', $name)
+    ->execute();
   cache_clear_all('variables', 'cache');

code looks good to me. nice work.

Is this chunck correct?

 function registry_cache_path_files() {
     foreach ($used_code as $type => $names) {
-      $type_sql[] = "(name IN (" . db_placeholders($names, 'varchar') . ") AND type = '%s')";
-      $params = array_merge($params, $names);
-      $params[] = $type;
-    }
-    $res = db_query("SELECT DISTINCT filename FROM {registry} WHERE " . implode(' OR ', $type_sql), $params);
-    while ($row = db_fetch_object($res)) {
-      $files[] = $row->filename;
+      $select->condition('name', $names, 'IN');
     }

The AND type = '%s'" stuff seem to be missing?

Committed to CVS HEAD. Thanks.