Problem/Motivation

readAttribute() is deprecated and will be removed in PHPUnit 9.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3126970-6.patch4.73 KBmondrake
#2 3126970.patch4.95 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3126970.patch4.95 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3126970.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Postponed
Issue tags: +PHPUnit 9

Same as #3126971-3: Replace usage of getObjectAttribute() that is deprecated, we need to wait for the assertAttribute* issues to get in first.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Assigned: Unassigned » mondrake
Status: Postponed » Needs work
Issue tags: +Needs reroll

This can be worked on now, on it.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3126970-6.patch4.73 KB

Just rerolled.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

I only rerolled, I think I can RTBC this. The deprecated assertions on internal object properties were replaced by the usual reflection dance. With this in we can unblock #3126971: Replace usage of getObjectAttribute() that is deprecated that has to wait since getObjectAttribute calls readAttribute itself in PHPUnit code.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Reroll looks fine, consider this an RTBC of the reroll :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 9.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed c0f2b559aa to 9.1.x and 076d6f4539 to 9.0.x. Thanks!

  • alexpott committed c0f2b55 on 9.1.x 
    Issue #3126970 by mondrake, longwave: Replace usage of readAttribute()...

  • alexpott committed 076d6f4 on 9.0.x 
    Issue #3126970 by mondrake, longwave: Replace usage of readAttribute()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Assigned: mondrake » Unassigned