The problem has been created by #3120096: Support contrib database driver directories in a fixed location in a module. The patch uses the shorthand syntax [] for lists. The problem is that was only introduced in PHP 7.1. See: https://www.php.net/manual/en/migration71.new-features.php#migration71.n....
Link to testbot result: https://www.drupal.org/pift-ci-job/1647406.

CommentFileSizeAuthor
#5 3126923-5.patch1.16 KBdaffie
#5 interdiff-3126923-2-5.txt559 bytesdaffie
#2 3126923-2.patch1.17 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
FileSize
3126923-2.patch1.17 KB
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Database/Database.php
@@ -568,7 +568,7 @@ public static function findDriverAutoloadDirectory($namespace, $root) {
-    [, $module, $module_relative_namespace] = explode('\\', $namespace, 3);
+    list($first, $module, $module_relative_namespace) = explode('\\', $namespace, 3);

Let's not add a $first here. It's an unnecessary difference.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Needs review
FileSize
interdiff-3126923-2-5.txt559 bytes
3126923-5.patch1.16 KB

Updated the patch for the comment from @alexpott. Thank you for the review.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community

All looks good here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 70dd2c2 and pushed to 8.9.x. Thanks!

Committing since this fixes a HEAD fail and is functionally exactly the same.

  • alexpott committed 70dd2c2 on 8.9.x 
    Issue #3126923 by daffie: HEAD is broken for Drupal 8.9 with PHP 7.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.