Replace non-test usages of \Drupal::request() with IoC injection

Kindly review a patch.

@Hardik_Patel_12 MailManager is pending of Ioc service injection. You can inject the request_stack service in it.
example:
$this->request = $request_stack->getCurrentRequest();

Injected \Drupal::request() call in MailManager class , kindly review a new patch.

Tasks left:

1. Check if there are more to do in non-test code.
2. Add change record(s)

Here I have made changes as suggested in comment #9, please review.

@nikitagupta thanks for working on this issues , but we need to inject Request(\Drupal::request()) service before replacements as we have done in core/lib/Drupal/Core/Mail/MailManager.php file.

Solving failed test cases of #10 , if we want do changes for only non-test file then this test cases will always gone be fail.

core/lib/Drupal/Core/Render/Element/RenderElement.php:349:        $settings['options']['query'] += \Drupal::request()->query->all();

FOr this file \Drupal::request() call is under static function so this looks ok to me.

core/lib/Drupal/Core/Database/Query/TableSortExtender.php:37:    $context = TableSort::getContextFromRequest($header, \Drupal::request());
core/lib/Drupal/Core/Entity/Query/QueryBase.php:333:    $order = TableSort::getOrder($headers, \Drupal::request());
core/lib/Drupal/Core/Entity/Query/QueryBase.php:334:    $direction = TableSort::getSort($headers, \Drupal::request());
core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php:94:    $request = \Drupal::request();

For this files can anyone suggest good way to inject \Drupal::request() call.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

At this time we will need a D10 version of the patch.

Also D10 should be checked to see if there are additional instances of \Drupal::request() that need to be addressed.

Thanks

reroll for drupal 10

Still seem to be instances

ViewExecutable
DbUpdateController

Not sure if entities or traits count.

Updating deprecation message for drupal:11.0.0.
The invocation of \Drupal::request() is located within a static function in DbUpdateController, making it uncertain whether it should be modified.

Should use constructor promotion now.

Hi @smustgrave,

Please review.

Thanks
Samit K.

Left a comment but not sure we can fully remove parameters and add new ones without doing a BC step.

Also what was the search that was ran to find these, imagine there are more.

core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php also has a call to \Drupal::request() as noted in #3373074: Call to a member function has() on null in Drupal\Core\Mail\Plugin\Mail\PhpMail->mail().