Luckily, most callbacks seem to be on Render Element plugins, and those already are RenderCallbackInterface through ElementInterface.

Starting here with the ones that I'm seeing in our project, there are more, some functions will need to be converted into static methods or methods on services.

@see Render callbacks must be a closure or implement TrustedCallbackInterface or RenderElementInterface

CommentFileSizeAuthor
#6 webform-trusted-callbacks-3120697-6.patch4.69 KBBerdir
#2 webform-trusted-callbacks-3120697-2.patch1.23 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
webform-trusted-callbacks-3120697-2.patch1.23 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Issue summary: View changes

Adding links to the change record.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

The only procedural callback function that I have found is _webform_bootstrap_webform_element_webform_likert_pre_render()

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Yeah, that's possible, I just fixed the ones that were breaking my tests :) The referenced meta issue has a few more examples too there might also be some that aren't covered by tests.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
webform-trusted-callbacks-3120697-6.patch4.69 KB

Did fine one or two more, but not much.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Patch looks fine to me. Maybe someone else can review it. Otherwise, we can make it postponed until Drupal 8.7 is no longer support.

strozx’s picture

strozx CreditAttribution: strozx at Agiledrop - Your Trusted Drupal Teammates commented
Status: Needs review » Reviewed & tested by the community

Hi, I also tested the patch and it looks good to me.

Regards, Strozx

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Postponed
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Title: [Drupal 8.8] #pre_render callbacks must be implement TrustedCallbackInterface or RenderCallbackInterface » [Drupal 8.8.x] #pre_render callbacks must be implement TrustedCallbackInterface or RenderCallbackInterface

  • Berdir authored a1606a9 on 8.x-5.x 
    Issue #3120697 by Berdir: [Drupal 8.8.x] #pre_render callbacks must be...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Rob230’s picture

Rob230 CreditAttribution: Rob230 as a volunteer and at CTI Digital commented

This has broken Drupal 8.7 support, so lots of sites on 8.7 have a fatal error - interface not found.

Should release 8.x-5.15 have a depdency or warning added?

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

@see #3145249: Core requirements for Drupal 8.7