COPYRIGHT.txt outdated

Hi @bertboerland,
I have added a patch for update the COPYRIGHT.txt file Please have a look at my patch and let me know if there is any issue.

The changes in the patch look good to me.
For me it is RTBC.

Hi @daffie,@bertboerland,
I have updated the Symfony version 4 in the copyright file please take a look and let me know if there is an issue.

I have taken another good look at the COPYRIGHT.txt file and I think we should do a lot more. We need to add/remove/update all mentioned projects. Do we still use them in core or can they be removed. Do new ones need to be added and for the listed ones which need to be updated. See core/composer.json for the dependencies of Drupal core.

For the patch from comment #7: looks good. More needs to be done.

Hi @daffie,

In the core, we have file name MAINTAINERS.txt where we have a list of the third-party project used with there Maintainers.

Hi @daffie,

I have updated patch and add MAINTAINERS.txt reference in copyright.txt file please take a look and let me know if there is an issue.

@Raunak.singh: The MAINTAINERS.txt file has the list of people who maintain the Drupal core project. The COPYRIGHT.txt file has the list of copyright ownersof the Drupal core project and it dependencies. The first line of that file is for the Drupal core project: "All Drupal code is Copyright 2001 - 2020 by the original authors." The list below: "Drupal includes works under other copyright notices and distributed according to the terms of the GNU General Public License or a compatible license, including:" needs updating for all the current dependencies for DRupal core. The list of current dependencies of Drupal core can be found in the file core/composer.json.

This can be removed:

+++ b/core/COPYRIGHT.txt
@@ -16,6 +16,10 @@ http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+You should have drupal third party dependencies and Maintainers
+infomration file as MAINTAINERS.txt; if not, please see
+https://api.drupal.org/api/drupal/core!MAINTAINERS.txt/9.0
+

Hi daffie,

I have updated my patch with all current dependencies of Drupal core found in the file core `/composer.json` Please take a look and let me know if there is an issue.

@Raunak.singh Could you be so kind to add an interdiff.txt the next time. It makes reviewing your patch a lot easier. Thanks! Good work!

The patch looks good.
There is only 1 nitpick and that can be corrected on commit.
For me it is RTBC.

+++ b/core/COPYRIGHT.txt
@@ -24,45 +24,69 @@ Javascript
\ No newline at end of file

Nitpick: The patch needs an extra new line.

1. +++ b/core/COPYRIGHT.txt
   @@ -24,45 +24,69 @@ Javascript
   -  jQuery Mousewheel - Copyright (c) 2010 Brandon Aaron
   -    (http://brandonaaron.net)
   +  jQuery Mousewheel - Copyright OpenJS Foundation and other contributors, (https://openjsf.org/)
   

   This is over 80 characters and needs to be wrapped.

2. +++ b/core/COPYRIGHT.txt
   @@ -24,45 +24,69 @@ Javascript
    PHP
    
   -  ArchiveTar - Copyright (c) 1997 - 2008 Vincent Blavet
   +  ArchiveTar - Copyright (c) 2010 - 2020 Michiel Rook.
    
   -  Doctrine Common - Copyright (c) 2006 - 2012 Alexander Mols, Benjamin Eberlei,
   +  Doctrine Common - Copyright (c) 2006 - 2015 Alexander Mols, Benjamin Eberlei,
        Fabio B. Silva, Guilherme Blanco, Johannes M. Schmitt, Jonathan Wage,
        Lukas K. Smith, Marco Pivetta et al.
    
   -  Symfony2 - Copyright (c) 2004 - 2012 Fabien Potencier
   +  Symfony 4.4 - Copyright (c) 2004 - 2020 Fabien Potencier
        - YUI - Copyright (c) 2010 Yahoo! Inc.
        - Zend Framework (1.10dev - 2010-01-24) - Copyright (c) 2005-2010 Zend
          Technologies USA Inc. (http://www.zend.com)
    
   -  Twig - Copyright (c) 2009 Twig Team
   +  Twig 2 - Copyright (c) 2009 - 2020 by the Twig Team.
   +
   +  TYPO3 - Copyright (c) 2018 TYPO3 project and other contributors,
   +    (https://typo3.org).
   +
   

   So the PHP dependencies are different from the JS ones. For the JS dependencies, they are actually committed to core, in core/assets/vendor/

   For these PHP dependencies, though, they're all Composer dependencies and they contain their own copyright information inside the package. At one point our Composer vendor directory was committed to our repo, but it hasn't been in the past four years. I don't think we should be including data from package managers here. It's completely unmaintainable to do that. This whole section should be removed.

   Since the tarballs include vendor, if we wanted, we could replace the whole section with a one-liner, something like:

   PHP

   Drupal depends on numerous PHP Composer packages. All Composer packages retain the copyright of the authors.

Also, we don't even depend on Doctrine Common anymore in D9, so yeah, the whole section should go.

Hi @xjm,

I have updated my patch. please take a look and let me know if there is an issue.

Thanks for the update.

1. +++ b/core/COPYRIGHT.txt
   @@ -29,7 +29,8 @@
   +  jQuery Bgiframe - Copyright (c) 2013 Brandon Aaron
   +    (http://brandonaaron.net)
   

   Not sure why this was wrapped as it was within 80 characters before. Were you trying to follow formatting like for other sections?

2. +++ b/core/COPYRIGHT.txt
   @@ -40,53 +41,29 @@
   -  jQuery Globalize - Copyright (c) 2012 Software Freedom Conservancy, Inc.
   +  jQuery Globalize - Copyright (c) 2012 Software Freedom Conservancy
   

   Not sure why ", Inc." was removed.

3. +++ b/core/COPYRIGHT.txt
   @@ -40,53 +41,29 @@
   -  jQuery Mousewheel - Copyright OpenJS Foundation and other contributors, (https://openjsf.org/)
   +  jQuery Mousewheel - Copyright OpenJS Foundation and other
   +    contributors, (https://openjsf.org/)
   

   Not sure why wrapping changed... "contributors," could be on previous line and still be within 80 characters.

4. +++ b/core/COPYRIGHT.txt
   @@ -40,53 +41,29 @@
   -  jQuery Metadata - Copyright (c) 2006 John Resig, Yehuda Katz, Jörn Zaefferer,
   -    Paul McLanahan
   +  jQuery Metadata - Copyright (c) 2006 John Resig, Yehuda Katz,
   +    Jörn Zaefferer, Paul McLanahan
   

   Not sure why wrapping changed. It was within 80 characters before.

5. +++ b/core/COPYRIGHT.txt
   @@ -40,53 +41,29 @@
   +  Drupal depends on numerous PHP Composer packages. All Composer
   +  packages retain the copyright of the authors.
   

   80 character wrapping needs updating (can move word(s) up one line).

Generally the formatting of this file is not great and not consistent but I'm not going to comment on the rest of it and stick with the interdiff :)

Hi @Kristen Pol,

I have updated the patch please take a look and let me know if there is an issue.

Thanks for the upatch.

1) Reviewed the interdiff and the changes in #23 seem to address all of the items noted in #22.

2) Double checked the items in #19 were addressed and see that the first item was addressed but not the second one.

This was supposed to be with the PHP section but it was split from it:

PHP

Drupal depends on numerous PHP Composer packages. All Composer packages retain the copyright of the authors.

+++ b/core/COPYRIGHT.txt
@@ -24,45 +24,46 @@ Javascript
 
 PHP
 

+++ b/core/COPYRIGHT.txt
@@ -24,45 +24,46 @@ Javascript
+
+  Drupal depends on numerous PHP Composer packages. All Composer packages
+    retain the copyright of the authors.

3) Moving back to "Needs work" based on above.

Hi @Kristen Pol,
I have updated the patch. please take a look.

Thanks for the update.

1) Reviewed the interdiff and it appears that this covers #19.2.

2) Patch applies to 8.9, 9.0, and 9.1.

[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < copyright-txt-outdated-3119733-26.patch
patching file core/COPYRIGHT.txt
[mac:kristen:drupal-8.9.x-dev]$ cd90
[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < copyright-txt-outdated-3119733-26.patch
patching file core/COPYRIGHT.txt
[mac:kristen:drupal-9.0.x-dev]$ cd91
[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < copyright-txt-outdated-3119733-26.patch
patching file core/COPYRIGHT.txt

3) Marking RTBC based on this and the recent comments above.

+++ b/core/COPYRIGHT.txt
@@ -24,45 +24,36 @@ Javascript
+  jQuery Mousewheel - Copyright OpenJS Foundation and other contributors,
...
+  jQuery UI - Copyright (c) 2015 by the authors and other contributors,
...
+  Sizzle.js - Copyright (c) 2016 JS Foundation and other contributors,

This is a small thing but the commas at the ends of these lines are not needed and are not consistent with the rest of the file. Thanks!

A novice could fix this issue so tagging accordingly.

Please review!

All points of @xjm are addressed.
Back to RTBC.

Committed to 9.1.x, and cherry-picked to 9.0.x, 8.9.x, and 8.8.x. Thanks!

Came across a duplicate of this and closed it.