Problem/Motivation

We noticed duplicate slash in fontawesome URL coming from shariff module like http://localhost/libraries/shariff//fontawesome-webfont.woff2

This is happening because `shariff.complete.css` is loaded with a duplicate slash like http://localhost/libraries/shariff//shariff.complete.css?q5mqex

Our project path for shariff CSS is web/libraries/shariff/shariff.complete.css

CommentFileSizeAuthor
#2 duplicate-slash-3113317-2.patch651 bytespivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new duplicate-slash-3113317-2.patch651 bytes

Here is a patch that fixes this. I've also added break; if file exist, no need to check the rest of the subfolders.

criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Needs review » Reviewed & tested by the community

Makes sense. Thank you.

  • criz committed e5aaa39 on 8.x-1.x authored by pivica 
    Issue #3113317 by pivica: Duplicate slash in fontawesome web font URL
criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.