Karen, regarding the new group_type column :
do you think we could make it a numeric column instead of varchar ? something like 0 is regular, 1 is combo ?

minor : unless I'm missing something, the cache clear in the update function looks unneeded, since update.php does a drupal_flush_all_caches() when it's finished ?

Comments

KarenS’s picture

KarenS CreditAttribution: KarenS commented

We could, but why? All other types are string type names -- content types, field types, widget types. Having a string for the group type seems the most logical to me. And I'm allowing for other types we might come up with in the future.

Does update.php always flush caches? I missed that.

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Active » Fixed

We talked offline and decided to leave this as it is, a string.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.