Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new1.43 KB

Kindly review a patch.

hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
kishor_kolekar’s picture

Status: Needs review » Reviewed & tested by the community

hi @Hardik_Patel_12

patch #2 LGTM + 1 RTBC

Thanks!

swatichouhan012’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +VbContribution2020
StatusFileSize
new1.45 KB
new606 bytes

Thanks @Hardik_Patel_12 , @kishor_kolekar for the patch. here is one more unused variable in test files. I have removed in new patch, kindly review.

andrey.troeglazov’s picture

Status: Needs review » Reviewed & tested by the community

The patch from #5 applies good for me.
Also I think empty line should be removed before return $form;
in tests/modules/ctools_wizard_test/src/Form/ExampleConfigEntityGeneralForm.php
see below.

/**
   * {@inheritdoc}
   */
  public function buildForm(array $form, FormStateInterface $form_state) {
    // The label and id will be added by the EntityFormWizardBase.

    return $form;
  }
shaktik’s picture

StatusFileSize
new162.36 KB

#5 Patch is no longer to apply
patch fail

Updated correct screenshot.

shaktik’s picture

Status: Reviewed & tested by the community » Needs work
shaktik’s picture

BTW I have created new issues and fixed all Unused variable.

shaktik’s picture

StatusFileSize
new126.3 KB
japerry’s picture

Status: Needs work » Closed (outdated)