The description for the return value of ModuleHandler::invokeAll() contains the following warning.

Note: integer keys in arrays will be lost, as the merge is done using array_merge_recursive().

The warning is true, but array_merge_recursive() is not used anymore. The warning should be the following one.

Note: integer keys in arrays will be lost, as the merge is done using Drupal\Component\Utility\NestedArray::mergeDeepArray().

CommentFileSizeAuthor
#3 moduleHandler-invokeAll-return-type-correction-3110620.patch1.35 KBsalah1
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

salah1’s picture

salah1
Location VA, U.S
CreditAttribution: salah1 as a volunteer commented
Assigned: Unassigned » salah1
salah1’s picture

salah1
Location VA, U.S
CreditAttribution: salah1 as a volunteer commented
FileSize
moduleHandler-invokeAll-return-type-correction-3110620.patch1.35 KB

I had few minutes and done this one. Thanks for catching the return type issue.

salah1’s picture

salah1
Location VA, U.S
CreditAttribution: salah1 as a volunteer commented
Status: Active » Needs review
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.0.x-dev » 8.8.x-dev
Status: Needs review » Reviewed & tested by the community

Nice work!

As a docs fix, this is eligible for backport to the bugfix version, so filing against 8.8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

BTW, the RTBC in #5 was intentional, which I should have stated explicitly. :) I looked at other mentions of array_merge_recursive() and they were all actual calls to that function, or (in one case) the docs of NestedArray::mergeDeepArray() itself.

  • catch committed 12610fd on 9.1.x 
    Issue #3110620 by salah1, xjm, kiamlaluno: Documentation for...

  • catch committed 1489271 on 9.0.x 
    Issue #3110620 by salah1, xjm, kiamlaluno: Documentation for...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x and cherry-picked back to 8.8.x, thanks!

  • catch committed 7e6c327 on 8.9.x 
    Issue #3110620 by salah1, xjm, kiamlaluno: Documentation for...

  • catch committed 7cc446f on 8.8.x 
    Issue #3110620 by salah1, xjm, kiamlaluno: Documentation for...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.