Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The todo from:
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21PathProce...
and was added here:
#2335661: Outbound path & route processors must specify cacheability metadata
The problem that I cannot find any mentions about UrlGenerator::fromPath()
, maybe it's a mistake and actually it should be UrlGeneratorInterface::generateFromPath()
. In any casse any of them not exist in core, so it's time to resolve the todo.
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff_3110580_2-11.txt | 1.35 KB | ankithashetty |
#11 | 3110580-11.patch | 2.94 KB | ankithashetty |
#5 | 3110580-5.patch | 585 bytes | Sivaji_Ganesh_Jojodae |
#2 | 3110580-2.patch | 1.37 KB | init90 |
Comments
Comment #2
init90Let's try
Comment #3
init90Ok, looks like we cannot simply remove this code. When I run tests with the next code change:
I've got the next test error:
So it mean that
processOutbound
still needed. Maybe, in that case, we can simply remove that todo?Comment #4
govind.maloo CreditAttribution: govind.maloo at Salsa Digital commentedComment #5
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae as a volunteer and commentedThe attached patch just removes the @todo. Needs Review.
Comment #9
longwaveFound this @todo again today.
As we are removing the processOutbound() method, we need to remove the explicit test for it as well. If there was something else relying on this behaviour I would hope it would be tested as part of something else, but that doesn't seem to be the case.
Comment #10
longwaveAlso the patch in #2 needs to remove the service tag, as in the patch in #2057577-4: Remove PathProcecssorFront::processOutbound once getPathFromRoute is not available anymore
Comment #11
ankithashettyAddressed the changes specified in #9 and #10, thanks!
Comment #12
longwaveThanks! This hasn't broken anything else according to tests, and the @todo says this should be removed when UrlGenerator::fromPath() was removed - which probably meant UrlGeneratorInterface::generateFromPath(), which was removed in #2575869: Remove all remaining usage of deprecated UrlGeneratorInterface::generateFromPath() and delete it - it seems this is OK to remove now.
Comment #13
alexpottCommitted 1d93843 and pushed to 9.3.x. Thanks!
Comment #14
alexpott