Functions are: Connection::query, Schema::fieldSetDefault, and Schema::fieldSetNoDefault, db_add_index()

There are kernel tests in DatabaseLegacyTest which verify that deprecation errors are triggered for specific functions or conditions. The format of some of these errors is incorrect. There are periods at the end of some, and instead of using the format 'drupal:9.0.0' it says 'Drupal 9.0.0'. I am working on a contrib database driver. I would like my driver to be able to both pass the core test suite, and pass phpcs. In this case, I have to either choose one, or disable phpcs for the lines that create the triggers.

CommentFileSizeAuthor
#11 3108540-11.patch5.27 KBBeakerboy
#3 drupal-3108540-deprecationErrors-3.patch14.39 KBBeakerboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Beakerboy created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Issue tags: +Contrib database driver
Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
FileSize
drupal-3108540-deprecationErrors-3.patch14.39 KB

Patch for deprecation formatiing.

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Status: Active » Needs review
bronk’s picture

bronk CreditAttribution: bronk at VMLY&R commented

Patch applied. Tests passed and I'm not seeing any PHPCS errors related to this after applying. I also reviewed each file manually for consistency. Patch in #3 covers all instances.

bronk’s picture

bronk CreditAttribution: bronk at VMLY&R commented
Status: Needs review » Reviewed & tested by the community

  • catch committed aca5ddd on 8.9.x 
    Issue #3108540 by Beakerboy, bronk: The format of the deprecation errors...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed aca5ddd and pushed to 8.9.x. Thanks!
Cherry-picked to 8.8.x

  • catch committed b137c46 on 8.8.x 
    Issue #3108540 by Beakerboy, bronk: The format of the deprecation errors...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
FileSize
3108540-11.patch5.27 KB

Apperantly a ".x" is now not allowed in the version.