Problem/Motivation

When you install the Umami profile, the Layout Builder and Layout Discovery modules are enabled by default. However, currently only the recipes content type is using layout builder. This means that there's some disparity on how we expect users to make changes to the page layout of recipes versus articles and basic page.

Proposed resolution

Enable layout builder by default on all content types to make it easier for users to modify the layout of these pages. This ensures that new-to-Drupal users have a good experience and see how powerful Drupal is.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 interdiff_9-14.txt982 bytesraman.b
#14 3108503-14.patch16.09 KBraman.b
#7 interdiff_5-7.txt373 bytesvsujeetkumar
#7 3108503_7.patch16.45 KBvsujeetkumar
#5 interdiff-2-5.txt15.49 KBkjay
#5 drupal-umami-enable-layout-builder-ctypes-default-3108503-5.patch16.01 KBkjay
#2 drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch7.39 KBkjay

Issue fork drupal-3108503

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

kjay’s picture

kjay commented
Status: Active » Needs review
StatusFileSize
new drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch7.39 KB

Attached is a patch that does nothing more than enable Layout Builder for the Page and Article content types in Umami. It would be great to hear thoughts on the following notes:

  1. I think it makes sense to allow users to vary the layout per node and so I have attempted to enable the 'Allow each content item to have its layout customized.' option on both the Page and Article content types but only Page has made this checkbox option available. Does anyone know why this is the case and do we agree it is a benefit for the demo to allow nodes to be overridden for layout?
  2. I have created a separate issue to use layout builder for the front page of Umami, which would be a helpful UX improvement. It would be great to get some reviews of that work in progress. #3113767: Use layout builder for Umami's front page and improve the author experience

Status: Needs review » Needs work

The last submitted patch, 2: drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch, failed testing. View results

markconroy’s picture

markconroy commented

Hi @kjay

This looks great, and is a great demo of the power of Drupal OOTB.

Two items that came up during our testing:

  1. Can we enable 'Full content' view mode for basic page and article, like we have for recipe.
  2. You need to click the checkbox to say "Allow each content item to have its layout customized." or else the "Layout" tab is not available on the node page to let an article override the global layout.

Besides those two items, great work. Thanks.

kjay’s picture

kjay commented
StatusFileSize
new drupal-umami-enable-layout-builder-ctypes-default-3108503-5.patch16.01 KB
new interdiff-2-5.txt15.49 KB

Thanks @markconroy for the review
You were right, enabling the 'Full content' display made the 'Allow each content item to have its layout customized.' option to become available.

Attached is a patch that takes care of the two points you have suggested but does not yet fix the tests.

Leaving as 'needs work' due to the tests to be done.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
StatusFileSize
new 3108503_7.patch16.45 KB
new interdiff_5-7.txt373 bytes

Fixed test, Please review.

Status: Needs review » Needs work

The last submitted patch, 7: 3108503_7.patch, failed testing. View results

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

markconroy’s picture

markconroy commented
Status: Needs work » Needs review

Setting to needs review to let the test bots do their magic.

markconroy’s picture

markconroy commented
Issue tags: +Europe2020

Adding europe2020 tag so this can be worked on during DrupalCon

markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

I'm going to mark this as RTBC.

It installs fine, has no custom code besides what Drupal config exports, and each content type is now using Layout Builder for "Full content" view mode.

Thanks for working on this @kjay @vsujeetkumar

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Unfortunately, the latest patch has a test failure and I believe it should be testing on 9.2.x. Setting NW.

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
StatusFileSize
new 3108503-14.patch16.09 KB
new interdiff_9-14.txt982 bytes

Resolving the failed test case

markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

Thanks for that review @quietone

Thanks for the new patch @raman.b

RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b4311ce and pushed to 9.2.x. Thanks!

  • alexpott committed b4311ce on 9.2.x 
    Issue #3108503 by kjay, raman.b, vsujeetkumar, markconroy: Enable layout...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

effulgentsia’s picture

effulgentsia commented
Title: Enable layout builder by default on all content types » Enable layout builder by default on all content types in Umami
Issue tags: +9.2.0 release highlights

I don't know if we want to highlight Umami stuff in the release highlights, but if we do, I think this is a worthy item to include. Tagging for now, just in case.