Problem/Motivation

Symfony 3.4 provides a shortcut to inject all services tagged with a specific tag, which is a common need in some applications, so you don't have to write a compiler pass just for that.

However, when you use a tagged argument, that argument is converted to \Symfony\Component\Yaml\Tag\TaggedValue by the container builder.

These types of arguments are not supported by \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue().

Proposed resolution

Convert \Symfony\Component\Yaml\Tag\TaggedValue to a string so we can dump it.

Remaining tasks

User interface changes

None

API changes

No change.

Data model changes

None

CommentFileSizeAuthor
#18 3108039-nr-bot.txt152 bytesneeds-review-queue-bot
#8 3108039-8-complete.patch3.29 KBbonrita
#8 3108039-8-tests.patch2.09 KBbonrita
#6 3108039-6-complete.patch3.05 KBbonrita
#6 3108039-5-test.patch1.72 KBbonrita
#5 3108039-5-complete.patch3.06 KBbonrita
#5 3108039-5-test.patch1.72 KBbonrita
#2 3108039-2.patch3.04 KBbonrita

Comments

bonrita created an issue. See original summary.

bonrita’s picture

bonrita commented
StatusFileSize
new 3108039-2.patch3.04 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3108039-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bonrita’s picture

bonrita commented
StatusFileSize
new 3108039-5-test.patch1.72 KB
new 3108039-5-complete.patch3.06 KB
bonrita’s picture

bonrita commented
StatusFileSize
new 3108039-5-test.patch1.72 KB
new 3108039-6-complete.patch3.05 KB
bonrita’s picture

bonrita commented
Status: Needs work » Active
bonrita’s picture

bonrita commented
StatusFileSize
new 3108039-8-tests.patch2.09 KB
new 3108039-8-complete.patch3.29 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

If you change the status to "needs review" and upload a patch, the tests will automatically run.

bonrita’s picture

bonrita commented

Thanks @longwave for the information. Let me do that.

bonrita’s picture

bonrita commented
Category: Task » Feature request

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3108039-nr-bot.txt152 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented

it still makes sense as SF parser is default now

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.