Fatal error: undefined method DatabaseSchema_mysql::escapeTable() [#310607]

A method is called incorrectly in mysql columnExists(). The resulting error message is An error occurred. Fatal error: Call to undefined method DatabaseSchema_mysql::escapeTable() in /includes/database/mysql/schema.inc on line 22

It's a minor bug but is blocking at least one other patch from being reviewed.

Comment	File	Size	Author
#7	d7-testExists.patch	1.33 KB	mfb
#7
#5	d7-testExists.patch	1.33 KB	mfb
#5
#3	d7-testExists.patch	1.2 KB	mfb
#3
	d7.escapeTable.patch	921 bytes	mfb

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Dries CreditAttribution: Dries commented 19 September 2008 at 20:30

Status:

Needs review

» Needs work

Good catch. Did you check the other database layers to make sure there are no copy-paste errors made? :)

I've committed this patch to CVS HEAD.

Seems like we did not have tests for this so I'm marking this 'code needs work'. Hopefully tests still follow.

Comment #2

mfb

they or he

CreditAttribution: mfb commented 19 September 2008 at 20:36

pgsql uses db_escape_table(). Is that the preferred way to call escapeTable()? If so I should reroll the patch. Test to follow..

Comment #3

mfb

they or he

CreditAttribution: mfb commented 21 September 2008 at 18:45

Status:

Needs work

» Needs review

File	Size
d7-testExists.patch	1.2 KB

Seems like there's a need for unit tests for each function in the db layer. For now I added some tests for db_*_exists() to the regression tests.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 12 November 2008 at 05:40

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #5

mfb

they or he

CreditAttribution: mfb commented 13 November 2008 at 13:02

Status:

Needs work

» Needs review

File	Size
d7-testExists.patch	1.33 KB

here's a reroll splitting it up into two different test methods. note, maybe these should go in some unit test class rather than regression test class.