Several issues coming out of PHPCS with the current code, and the module is not D9 compatible.

FILE: src/Form/AWSConnectorForm.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------
 80 | WARNING | [x] There must be no blank line following an inline comment
 80 | WARNING | [ ] There must be no blank line following an inline comment
 82 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: src/Credentials/AWSCredentialProvider.php
------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------
  19 | ERROR   | Doc comment short description must be on a single line, further text should be a
     |         | separate paragraph
  33 | WARNING | Unused bound variable $filename.
  77 | ERROR   | Doc comment short description must be on a single line, further text should be a
     |         | separate paragraph
 124 | WARNING | Unused variable $result.
------------------------------------------------------------------------------------------------------

Comments

mikemadison created an issue. See original summary.

mikemadison’s picture

Status: Active » Needs review
StatusFileSize
new3.36 KB
mikemadison’s picture

StatusFileSize
new3.35 KB

Missed some example text in a comment in #2. Fixed in this patch.

mikemadison’s picture

Status: Needs review » Fixed
mikemadison’s picture

Status: Fixed » Closed (fixed)