Problem/Motivation

As part of #3094468: [plan] Update core JavaScript (and CSS) dependencies prior to 9.0.0-beta1 we need to update SortableJS to 10.0.1

Proposed resolution

update it

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 interdiff.txt84 KBlauriii
#4 interdiff_2-4.txt480 bytesbnjmnm
#4 3101661-4.patch84.63 KBbnjmnm
#2 3101661-2.patch84.46 KBbnjmnm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Assigned: bnjmnm » Unassigned
Status: Active » Needs review
FileSize
3101661-2.patch84.46 KB

The differences between 10.0.0 and 10.0.1 are described here: https://github.com/SortableJS/Sortable/releases/tag/1.10.1
Neither of the two changes impact core's use, so this should uneventful.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented 
+++ b/core/core.libraries.yml
@@ -611,7 +611,7 @@ popperjs:
   license:
     name: MIT
     url: https://github.com/SortableJS/Sortable/tree/master#mit-license

In most other libraries we link to the license on the tag we are using. We should probably also update this to https://github.com/SortableJS/Sortable/tree/1.10.1#mit-license

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
FileSize
3101661-4.patch84.63 KB
interdiff_2-4.txt480 bytes

#3👌

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Needs review » Reviewed & tested by the community

Did some manual testing Layout Builder, Media Library and CKEditor which are the 3 places I see sortable being used. they all worked fine with no JS errors 🎉

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Update SortableJS to 10.0.1 » Update SortableJS to 1.10.1

Version number typo was misleading.

  • lauriii committed 7ef9a12 on 9.0.x 
    Issue #3101661 by bnjmnm, tedbow: Update SortableJS to 1.10.1
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.0.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed
FileSize
interdiff.txt84 KB 
+++ b/core/assets/vendor/sortable/Sortable.min.js
@@ -1,2 +1,2 @@
\ No newline at end of file

I tried to md5 compare this file to the original file from Github but it didn't match. This was because there was a new line at the end of the file. After removing the new line md5 checksums matched.

Committed 7ef9a12 and pushed to 9.0.x and 8.9.x. Thanks!

  • lauriii committed 1b5c981 on 8.9.x 
    Issue #3101661 by bnjmnm, tedbow: Update SortableJS to 1.10.1

(cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.