The javascript file contains the comments for the blocks.js file. Simply update to make sense for taxonomy.

CommentFileSizeAuthor
#5 interdiff-3101635-1-5.txt445 bytesmrinalini9
#5 3101635-5.patch892 bytesmrinalini9
#2 3101635-1.patch906 bytesTylerMarshall
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TylerMarshall created an issue. See original summary.

TylerMarshall’s picture

TylerMarshall CreditAttribution: TylerMarshall as a volunteer and at Acro Commerce commented
FileSize
3101635-1.patch906 bytes

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Needs work
Issue tags: +Novice

Thanks for the patch.

1) Confirmed the taxonomy.es6.js file has this block text.

2) Searched taxonomy.es6.js for other mentions of "block" and found none.

3) Patch applied cleanly in 8.9, 9.0, and 9.1.

[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < 3101635-1.patch 
patching file core/modules/taxonomy/taxonomy.es6.js

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < 3101635-1.patch 
patching file core/modules/taxonomy/taxonomy.es6.js

[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < 3101635-1.patch 
patching file core/modules/taxonomy/taxonomy.es6.js

4) Reviewed the text changes and have one nitpick:

Reorganize the terms in a Vocabulary.

could be updated to refer to just taxonomy instead of Vocabulary, e.g.

a) Reorder a term in the taxonomy table. (more similar to old wording)

or

b) Reorganize taxonomy terms. (more similar to new wording)

or

c) Reorder taxonomy terms.

The use of lowercase taxonomy is intentional based on other comments in the taxonomy module.

Personally, I'd go with c) for simplicity.

5) Marking "Needs work" for consideration of 4). Also marking "Novice" as the change is simple.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3101635-5.patch892 bytes
interdiff-3101635-1-5.txt445 bytes

Rerolled patch to 9.1.x along with the changes mentioned in #4.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Thanks for the update.

1) The change in #5 addresses the recommendation in #4.

2) Patch applies cleanly in 8.8, 8.9, 9.0, and 9.1.

[mac:kristen:drupal-8.8.x-dev]$ patch -p1 < 3101635-5.patch
patching file core/modules/taxonomy/taxonomy.es6.js
[mac:kristen:drupal-8.8.x-dev]$ cd89
[mac:kristen:drupal-8.9.x-dev]$ patch -p1 < 3101635-5.patch
patching file core/modules/taxonomy/taxonomy.es6.js
[mac:kristen:drupal-8.9.x-dev]$ cd90
[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < 3101635-5.patch
patching file core/modules/taxonomy/taxonomy.es6.js
[mac:kristen:drupal-9.0.x-dev]$ cd91
[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < 3101635-5.patch
patching file core/modules/taxonomy/taxonomy.es6.js

3) Tests pass (in 9.1).

4) Marking RTBC for the documentation fix.

  • xjm committed 5c2f38a on 9.1.x 
    Issue #3101635 by mrinalini9, TylerMarshall, Kristen Pol: Update...

  • xjm committed 91f5e34 on 9.0.x 
    Issue #3101635 by mrinalini9, TylerMarshall, Kristen Pol: Update...

  • xjm committed 73e9c15 on 8.9.x 
    Issue #3101635 by mrinalini9, TylerMarshall, Kristen Pol: Update...

  • xjm committed 597a515 on 8.8.x 
    Issue #3101635 by mrinalini9, TylerMarshall, Kristen Pol: Update...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.1.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Nice catch.

I was going to say this was missing the transpiled changes to taxonomy.js, but since it's only changing comments and those get stripped, there's no effect on the transpiled output.

Committed to 9.1.x, and cherry-picked to 9.0.x, 8.9.x, and 8.8.x as a patch-release-eligible documentation bugfix. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.