Update jquery-once to 2.2.3 [#3100943]

Problem/Motivation

As part of #3094468: [plan] Update core JavaScript (and CSS) dependencies prior to 9.0.0-beta1 we need to update jquery-once 2.2.3

It looks there haven't been big changes https://github.com/RobLoach/jquery-once/releases

Proposed resolution

Update it

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#3	interdiff-2-3.txt	618 bytes	tedbow
#3	3100943-3.patch	6.88 KB	tedbow
#3	9.0.x: PHP 7.2 & MySQL 5.7 27,654 pass
#2	3100943.patch	6.28 KB	tedbow
#2	9.0.x: PHP 7.2 & MySQL 5.7 27,601 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 December 2019 at 19:19

tedbow created an issue. See original summary.

Comment #2

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 13 December 2019 at 19:29

Assigned:	tedbow	» Unassigned
Status:	Active	» Needs review

File	Size
3100943.patch	6.28 KB
9.0.x: PHP 7.2 & MySQL 5.7 27,601 pass

Here it is

Comment #3

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 17 December 2019 at 14:27

File	Size
3100943-3.patch	6.88 KB
9.0.x: PHP 7.2 & MySQL 5.7 27,654 pass
interdiff-2-3.txt	618 bytes

The tests passed!🎉
updated core.libraries.yml with the new version number

Comment #4

bnjmnm

he/him

English

Ann Arbor, MI

CreditAttribution: bnjmnm at Acquia commented 17 December 2019 at 17:57

Status:

Needs review

» Reviewed & tested by the community

The difference between 2.2.0 and 2.2.3 is pretty minor and everything looks good here.

+++ b/core/core.libraries.yml
@@ -391,10 +391,10 @@ jquery.joyride:
-    url: https://raw.githubusercontent.com/RobLoach/jquery-once/2.2.0/LICENSE.md
+    url: https://github.com/RobLoach/jquery-once/blob/2.2.3/LICENSE.md

I did notice the license points to the github formatted version vs the raw.githubusercontent.com, but it looks like the two are used interchangeably in core.libraries.yml.

Comment #5

19 December 2019 at 12:01

lauriii committed b309bbf on 9.0.x

Issue #3100943 by tedbow, bnjmnm: Update jquery-once to 2.2.3

Comment #6

19 December 2019 at 12:02

lauriii committed 4e5da5d on 8.9.x

Issue #3100943 by tedbow, bnjmnm: Update jquery-once to 2.2.3

(cherry...

Comment #7

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 19 December 2019 at 12:02

Version:	9.0.x-dev	» 8.9.x-dev
Status:	Reviewed & tested by the community	» Fixed

diff --git a/core/assets/vendor/jquery-once/jquery.once.js b/core/assets/vendor/jquery-once/jquery.once.js
old mode 100644
new mode 100755

diff --git a/core/assets/vendor/jquery-once/jquery.once.min.js b/core/assets/vendor/jquery-once/jquery.once.min.js
old mode 100644
new mode 100755

diff --git a/core/assets/vendor/jquery-once/jquery.once.min.js.map b/core/assets/vendor/jquery-once/jquery.once.min.js.map
old mode 100644
new mode 100755

Reverted these file permission changes and confirmed that the md5 matched with https://github.com/RobLoach/jquery-once/releases/tag/2.2.3.

Committed b309bbf and pushed to 9.0.x and 8.9.x. Thanks!