In #3059391: Use drupal_http_build_query() in drupal_http_request() we changed drupal_http_request() to use drupal_http_build_query() instead of PHP's http_build_query().

However, http_build_query() will accept objects or arrays, whereas drupal_http_build_query() will only take an array.

The code and comments need a small tweak to remove references to using objects; only arrays will work.

Patch on the way...

CommentFileSizeAuthor
#2 3098664-2.patch1.28 KBmcdruid

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

mcdruid commented
Status: Active » Needs review
StatusFileSize
new 3098664-2.patch1.28 KB
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Pending Drupal 7 commit

RTBC - Let's get this in.

Special sign-off from me as Core Committer: This belongs still in this release.

  • mcdruid committed cd37220 on 7.x 
    Issue #3098664 by mcdruid: drupal_http_build_query() only accepts arrays...
mcdruid’s picture

mcdruid commented
Assigned: mcdruid » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks for catching this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.