CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review. Attached you will find a patch based on a review with the coder module and a careful examination of the code. Thanks!

CommentFileSizeAuthor
#3 custom_pagers_i18n3.patch871 bytesSamLerner
#2 custom_pagers_i18n2.patch867 bytesSamLerner
#1 custom_pagers_coder3.patch5.16 KBSamLerner
#1 custom_pagers_i18n.patch5.76 KBSamLerner
custom_pagers_coder2.patch5.76 KBSamLerner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SamLerner’s picture

SamLerner CreditAttribution: SamLerner commented
FileSize
custom_pagers_i18n.patch5.76 KB
custom_pagers_coder3.patch5.16 KB

I've split the previous coder2.patch into two separate patches, one to handle just coder issues and the other to handle i18n issues.

SamLerner’s picture

SamLerner CreditAttribution: SamLerner commented
FileSize
custom_pagers_i18n2.patch867 bytes

Adding a second i18n patch that's just the i18n changes without the coder fixes.

SamLerner’s picture

SamLerner CreditAttribution: SamLerner commented
FileSize
custom_pagers_i18n3.patch871 bytes

Another update with several more i18n issues.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

custom_pagers_coder3.patch and custom_pagers_i18n3.patch both apply cleanly and look rtbc to me.

eaton’s picture

eaton CreditAttribution: eaton commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-6--1 branch, will be in the next release. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.