Problem/Motivation

Automated tests are failing with Drupal Core 8.8 and later with a deprecation notice:

Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

Proposed resolution

Implement a $defaultTheme for the functional tests to resolve the deprecation notice.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#2 3097604-2.patch880 bytesidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr as a volunteer commented
Status: Active » Needs review
FileSize
3097604-2.patch880 bytes

Attached patch implements a $defaultTheme for the functional tests to resolve the deprecation notice.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Needs review » Reviewed & tested by the community

Thank you @idebr. Good job!

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented

I'll prepare to committed it. Thank you again.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Parent issue: » #3083505: Test for Drupal 9 deprecations

I added a parent issue (Drupal 9 compatibility).

  • vuil committed 1e03497 on 8.x-1.x authored by idebr 
    Issue #3097604 by idebr, vuil: Automated tests are failing with Drupal...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Reviewed & tested by the community » Fixed

The patch is committed! I close the issue as Fixed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.