Downloading submissions per page

Reading the code, it looks good to me.

+        $webform_id = $webform->id();
+        $entity_id_options = $this->getOptionsNodesWithWebform($webform_id);

Perhaps $webform_id is not needed here; instead, inline $webform->id().

The problem is that the 'Submitted to' field can be any entity and the select menu is being limited to only nodes.

The only solution to improve the UX would be to use Ajax to update the entity id input based on the selected entity type.

Please review the attached patch.

The failing JavaScript test is unrelated. The patch can still be reviewed AS-IS.

Same solution with a reusable \Drupal\webform\Element\WebformAjaxElementTrait because it is time to make it easier to create a two-step cascading Ajax element.

I committed the patch. Please download the latest dev release to review.

Hi folks,

In patch 22 the database query
$entity_ids = Database::getConnection()->select('webform_submission', 's') + ->fields('s', ['entity_id']) + ->condition('s.webform_id', $webform->id()) + ->condition('s.entity_type', $entity_type) + ->execute() + ->fetchCol();
Is not really correct. I have around 180 webform submissions so I get 180 IDs here, but only 6 unique IDs. Some lines later it is checked for no more than 100 IDs to get not to many select items. I think this query should be grouped by entity_id.

Should I make a patch for this here?

Your probably just need to add SelectInterface::distinct() to the query.

There is no point using GROUP BY unless you also using an aggregate function. Use DISTINCT.

No problem, I just done it because of the sortorder at the end. Some times even group by is faster than distinct.