All of our boolean fields have a default value except this one, which means that PaymentMethod::isDefault() returns NULL instead of FALSE by default, breaking the assertFalse() comparison.

Discovered in #3093383: Fix the tests on Drupal 8.8-beta1.

The solution is to add a default value to FALSE, ensure that the test passes on 8.8, see if we need an update hook.

CommentFileSizeAuthor
#2 3093396-2-default-value.patch802 bytesbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Needs review
FileSize
3093396-2-default-value.patch802 bytes

Looks like an update function is not needed.

Let's see what the tests say.

  • bojanz committed 531979a on 8.x-2.x 
    Issue #3093396 by bojanz: PaymentMethod's is_default boolean is missing...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

I really did not expect this issue to be a one-line fix. Oh, well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.