Problem/Motivation

Recent commits have broken javascript coding standards.

yarn run v1.19.1
$ node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json .

/Users/alex/dev/sites/drupal8alt.dev/core/misc/dropbutton/dropbutton.es6.js
  234:132  error  Replace `⏎··········options.title⏎········` with `options.title`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/filter/filter.admin.es6.js
  59:56  error  Delete `⏎··············`  prettier/prettier
  61:1   error  Delete `··`               prettier/prettier
  62:17  error  Delete `··`               prettier/prettier
  63:1   error  Delete `··`               prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/quickedit/js/theme.es6.js
  37:25  error  Replace `⏎······settings.id⏎····` with `settings.id`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/system/js/system.date.es6.js
  41:46  error  Replace `⏎··········/\\?(.?)/gi,⏎··········(key,·value)·=>·(dateFormats[key]·?·dateFormats[key]·:·value)` with `/\\?(.?)/gi,·(key,·value)·=>⏎··········dateFormats[key]·?·dateFormats[key]·:·value`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/toolbar/js/toolbar.menu.es6.js
  200:69  error  Replace `⏎······options.action⏎····` with `options.action`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/user/user.es6.js
  50:267  error  Replace `⏎············translate.strengthTitle⏎··········` with `translate.strengthTitle`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/modules/user/user.theme.es6.js
  14:112  error  Replace `⏎······translate.confirmTitle⏎····` with `translate.confirmTitle`  prettier/prettier

/Users/alex/dev/sites/drupal8alt.dev/core/themes/stable/js/user.theme.es6.js
  14:124  error  Replace `⏎······translate.confirmTitle⏎····` with `translate.confirmTitle`  prettier/prettier

✖ 11 problems (11 errors, 0 warnings)
  11 errors, 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Proposed resolution

Fix them by running yarn run lint:core-js-passing --fix

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
6.06 KB
lauriii’s picture

Status: Needs review » Reviewed & tested by the community

Looks good! Thank you! 🙏

$ yarn run lint:core-js-passing
yarn run v1.12.3
$ node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json .
✨  Done in 11.41s.

  • larowlan committed 0a69c9c on 9.0.x
    Issue #3091672 by alexpott: Fix javascript coding standards
    
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed 0a69c9c and pushed to 9.0.x. Thanks!

c/p to 8.9.x

  • larowlan committed 98e3cac on 8.9.x
    Issue #3091672 by alexpott: Fix javascript coding standards
    
    (cherry...
alexpott’s picture

As these errors are on 8.8.x too I cherry-picked it back to that branch.

  • alexpott committed 7742491 on 8.8.x authored by larowlan
    Issue #3091672 by alexpott: Fix javascript coding standards
    
    (cherry...
larowlan’s picture

Version: 8.9.x-dev » 8.8.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.