Thanks for this awesome module, It will be nice to use 'entity media type' too. (Right now we can use 'node' type).

CommentFileSizeAuthor
#14 support_media_entity_type-3089597-14.patch1.19 KBdkosbob
#11 support_media_entity_type-3089597-9.patch1.53 KBgooddenis
#8 draggableviews-duplicates-items-3089597-8.png44.31 KBistryker
#5 Screenshot at Oct 24 22-18-14.png266.67 KBgooddenis
#3 support_media_entity_type-3089597-2.patch1.68 KBgooddenis
#2 support_media_entity_type-3089597-1.patch1.67 KBgooddenis

Comments

goodDenis created an issue. See original summary.

gooddenis’s picture

gooddenis commented
Status: Active » Needs review
StatusFileSize
new support_media_entity_type-3089597-1.patch1.67 KB

With this patch, you can use 'node type' or 'media type', but not both. Because in the 'draggableviews_structure' table we don't keep 'entity type' and 'parent entity type'.

gooddenis’s picture

gooddenis commented
StatusFileSize
new support_media_entity_type-3089597-2.patch1.68 KB

Fix getting entity, please use the latest path.

istryker’s picture

istryker commented

Tried your patch with Drupal core 8.7.7, latest 8.x-1.x. I see it does not work with a view of "Media" without your patch. With your patch it still does not work. No draggable + show up on the table.

Looking at the patch, it does look like it should work. What version of Core you using?

gooddenis’s picture

gooddenis commented
StatusFileSize
new Screenshot at Oct 24 22-18-14.png266.67 KB

It works for me at 8.7.8
Did you see 'Draggableviews: Media' in the 'FIELDS'?

  • goodDenis authored 98a25cb on 8.x-1.x 
    Issue #3089597 by goodDenis: Support media entity type
istryker’s picture

istryker commented
Status: Needs review » Fixed

Got it to work. Comitted

istryker’s picture

istryker commented
Status: Fixed » Needs work
StatusFileSize
new draggableviews-duplicates-items-3089597-8.png44.31 KB

Wait I think this needs works. After saving 1 view with 3 images, and having the draggableviews demo with 5 items, now there is duplicates. Images go from 3 items to 6, DV Demos goes from 5 to 8. I think its because they have conflicting entity Ids. See attached image.

duplicate entries

gooddenis’s picture

gooddenis commented
Assigned: gooddenis » Unassigned

I will try to check it, but right now I don't have much time, Changing the assigned status.

gooddenis’s picture

gooddenis commented
Assigned: Unassigned » gooddenis
gooddenis’s picture

gooddenis commented
Status: Needs work » Needs review
StatusFileSize
new support_media_entity_type-3089597-9.patch1.53 KB

The problem was with join `draggableviews_structure` table to the view. We should add additional conditions `view_name` and `view_display`.
The SQL query was
LEFT JOIN {draggableviews_structure} draggableviews_structure ON media_field_data.mid = draggableviews_structure.entity_id
and I change it to
LEFT JOIN {draggableviews_structure} draggableviews_structure ON media_field_data.mid = draggableviews_structure.entity_id AND (draggableviews_structure.view_name = 'VIEW_NAME' AND draggableviews_structure.view_display = 'VIEW_DISPLAY')
Added patch.

  • iStryker committed 606c58e on 8.x-1.x authored by goodDenis 
    Issue #3089597 by goodDenis, iStryker: Add additonal joins on view name...
istryker’s picture

istryker commented
Status: Needs review » Fixed

Test and committed. I am surprised this hasn't caused other problems with other issues.

dkosbob’s picture

dkosbob commented
StatusFileSize
new support_media_entity_type-3089597-14.patch1.19 KB

I'm fairly certain the views_query_alter committed in this issue broke the functionality of the module on my views. Removing it restores expected behavior. Here is a patch that just removes that for anyone who needs it, but it sounds like that may invalidate the work done earlier in this issue.

dkosbob’s picture

dkosbob commented
Status: Fixed » Needs review
gooddenis’s picture

gooddenis commented

Hello, @dkosbob
Could you provide some information about the problem? Do you have any error message?
This hook_views_query_alter change JOIN

LEFT JOIN {draggableviews_structure} draggableviews_structure ON media_field_data.mid = draggableviews_structure.entity_id
to
LEFT JOIN {draggableviews_structure} draggableviews_structure ON media_field_data.mid = draggableviews_structure.entity_id AND (draggableviews_structure.view_name = 'VIEW_NAME' AND draggableviews_structure.view_display = 'VIEW_DISPLAY')

istryker’s picture

istryker commented

In theory it shouldn't because view display and view name are already added to the database. The commit just adds them to the query.

gooddenis’s picture

gooddenis commented
Assigned: gooddenis » Unassigned
istryker’s picture

istryker commented
Status: Needs review » Fixed
Related issues: +#3158196: Allow any entity in DraggableViews::getIndex()

Reclosing isssue as only @dkosbob is having problems. There are other issue like his in other issues. Marking back as fixed for this issue.

Better solution #3158196: Allow any entity in DraggableViews::getIndex(). This is what I was looking for. It not mid or nid specific.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

robertom’s picture

robertom commented
Related issues: +#3153830: DraggableViews not working after update to 2.0.0

I have the same problem as @dkosbob

the problem is discussed on #3153830: DraggableViews not working after update to 2.0.0

dejan0’s picture

dejan0 commented

+1
same here