When cloneReferencedEntities is called it should dispatch events [#3089105]

Problem/Motivation

We have altered the cloning form (entity_clone_form), adding some extra parameters (in our case the entity clone language).

We can use these extra settings during clone using EntityCloneEvents::PRE_CLONE or EntityCloneEvents::POST_CLONE.

But these events are dispatched only when the first node is cloned. Child nodes which are cloned using cloneReferencedEntities function don't dispatch events.

It should be very useful if also when we clone child nodes the same events will be dispatched.

Comment	File	Size	Author
#11	entity_clone-3089105-11.patch	11.86 KB	lamp5
#8	3089105-8.patch	11.91 KB	upchuk
#6	entity_clone-3089105-6.patch	3.49 KB	lamp5
#2	entity_clone-cloneReferencedEntities_events-3089105.diff	3.19 KB	eithel

Comments

Comment #1

21 October 2019 at 08:06

eithel created an issue. See original summary.

Comment #2

eithel commented 21 October 2019 at 08:09

Status	File	Size
new	entity_clone-cloneReferencedEntities_events-3089105.diff	3.19 KB

I've upload a patch for this issue

Comment #3

eithel commented 21 October 2019 at 08:11

Issue summary:

View changes

Comment #4

lamp5

Polish

Rzeszow

commented 11 March 2020 at 09:37

Status:

Active

» Reviewed & tested by the community

Works perfect!

Comment #5

colan

he/him

English

Toronto 🇨🇦

commented 15 March 2021 at 14:24

Version:	8.x-1.0-beta3	» 8.x-1.x-dev
Status:	Reviewed & tested by the community	» Needs work

+++ b/src/EntityClone/Content/ContentEntityCloneBase.php
@@ -31,18 +34,24 @@ class ContentEntityCloneBase implements EntityHandlerInterface, EntityCloneInter
+	/**
+	 * @var \Symfony\Component\EventDispatcher\EventDispatcherInterface
+	 */
+	protected $event_dispatcher;
+
+	/**
+	 * Constructs a new ContentEntityCloneBase.
+	 *
+	 * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
+	 *   The entity type manager.
+	 * @param string $entity_type_id
+	 *   The entity type ID.
+	 * @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $event_dispatcher
+	 */

Tabs are being used here instead of spaces, which doesn't follow the coding standards.