Found two more deprecations today, the usage of entityManager in the EntityBundle views field:

  2x: EntityManagerInterface::getBundleInfo() is deprecated in drupal:8.0.0 and will be removed before drupal:9.0.0. Use \Drupal\Core\Entity\EntityTypeBundleInfoInterface::getBundleInfo() instead. See https://www.drupal.org/node/2549139.
    2x in ProductAdminTest::testMixedMode from Drupal\Tests\commerce_product\Functional

  1x: The property entityManager (entity.manager service) is deprecated in Drupal\commerce\Plugin\views\field\EntityBundle and will be removed before Drupal 9.0.0.
    1x in ProductAdminTest::testMixedMode from Drupal\Tests\commerce_product\Functional
CommentFileSizeAuthor
#3 3088606-3-entity-bundle-plugins.patch4.81 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: The EntityBundle views field is using the deprecated entityManager » The EntityBundle views plugins are using the deprecated entityManager

We have some in the views filter as well.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Needs review
FileSize
3088606-3-entity-bundle-plugins.patch4.81 KB

Injects the entity bundle info service into the field plugin, and starts using it.
Uses the already injected entity bundle info service in the filter plugin.

What remains is calculateDependencies() in the filter plugin, which we can't touch until we rebase on Drupal 8.8, since the entityTypeManager is only present there, not in 8.7.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Committed.

  • bojanz committed e493ea3 on 8.x-2.x 
    Issue #3088606 by bojanz: The EntityBundle views plugins are using the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.