Problem/Motivation

Finder's exclude is overly aggressive. It finds any vendor folder (as an example) and excludes it. That means thinks like #3088095: Automatic Updates isn't ready to handle composer sites, but has 3rd party dependencies of its own where we are trying to bundle php-signify in a vendor folder as part of the project fall on their face in build tests.

Proposed resolution

Switch to use notPath instead.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3088400-8.patch3.23 KBheddn
#8 interdiff_4-8.txt517 bytesheddn
#5 interdiff_3-4.txt500 bytesheddn
#5 3088400-4.patch3.17 KBheddn
#3 3088400-3_test_only.patch3.85 KBheddn
#3 3088400-3.patch3.17 KBheddn
#3 interdiff_2-3.txt3.63 KBheddn
#2 3088400.patch2.52 KBheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for European Commission and European Union Institutions, Agencies and Bodies, Drupal Association commented
Title: BuildTestBase->copyCodebase overly aggressive » BuildTestBase->copyCodebase overly aggressive in exclusions
Status: Active » Needs review
FileSize
3088400.patch2.52 KB

Probably needs more tests, but let's see how things go to begin with.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for European Commission and European Union Institutions, Agencies and Bodies, Drupal Association commented
FileSize
interdiff_2-3.txt3.63 KB
3088400-3.patch3.17 KB
3088400-3_test_only.patch3.85 KB

And here's some tests.

Status: Needs review » Needs work

The last submitted patch, 3: 3088400-3_test_only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for European Commission and European Union Institutions, Agencies and Bodies, Drupal Association commented
Status: Needs work » Needs review
FileSize
3088400-4.patch3.17 KB
interdiff_3-4.txt500 bytes

phpcs

The last submitted patch, 3: 3088400-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 5: 3088400-4.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for European Commission and European Union Institutions, Agencies and Bodies, Drupal Association commented
Status: Needs work » Needs review
FileSize
interdiff_4-8.txt517 bytes
3088400-8.patch3.23 KB
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM.

The tests still demonstrate that we didn't copy the root vendor directory.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed 3b6698e973 to 9.0.x and aa9d5a31dd to 8.9.x. Thanks!

Will backport once 8.8.x code freeze is over.

+++ b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php
@@ -540,13 +540,12 @@ public function copyCodebase(\Iterator $iterator = NULL, $working_dir = NULL) {
+        ->ignoreUnreadableDirs()

+1

  • alexpott committed 3b6698e on 9.0.x 
    Issue #3088400 by heddn, Mile23: BuildTestBase->copyCodebase overly...

  • alexpott committed aa9d5a3 on 8.9.x 
    Issue #3088400 by heddn, Mile23: BuildTestBase->copyCodebase overly...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Patch (to be ported) » Fixed

Discussed with @catch we agreed this was good to backport to 8.8.x

  • alexpott committed 8d8963f on 8.8.x 
    Issue #3088400 by heddn, Mile23: BuildTestBase->copyCodebase overly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.