Testing with Views RC2 and CCK RC7

Checkout out module HEAD as of today.

Added a single file file w/ upload widget to story type.

On node/add/story:

warning: in_array() [function.in-array]: Wrong datatype for second argument in /Users/Shared/www/AD-1.0-6.x/modules/acquia/filefield/filefield.module on line 289.

  if (!in_array('filefield_node_form_submit', $form['#submit'])) {
    $form['#submit'][] = 'filefield_node_form_submit';
  }

Lokks like it's no set.

CommentFileSizeAuthor
#1 not-set-arg-308832-1.patch1.04 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Active » Needs review
FileSize
not-set-arg-308832-1.patch1.04 KB

just need to check if before passing to in_array I think.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Reviewed & tested by the community

I patch above alleviates the error and is safe too.

Given that it's pretty trivial, I think it's RTBC

drewish’s picture

drewish CreditAttribution: drewish commented

this is a dupe of at least two issues (#296350: Wrong datatype and #305905: warning: in_array() in filefield.module ) but since it's got a patch it wins.

committed to HEAD.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Reviewed & tested by the community » Fixed

also marking #297395: warning: in_array() [function.in-array]: as a duplicate.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.