Follow up to #2044435: Convert pager.inc to a service We left an unused RequestStack property on \Drupal\views\Plugin\views\pager\SqlBase when switching to using PagerParameters.

We need to remove the unused property:

  /**
   * The request stack.
   *
   * @var \Symfony\Component\HttpFoundation\RequestStack
   */
  protected $requestStack;
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper created an issue. See original summary.

andypost’s picture

Version: 8.9.x-dev » 9.0.x-dev

Removal is 9.0 target

plach’s picture

Let's try to get this in before beta, otherwise we might have to provide some sort of BC. Also, I think this should still target D8, since it's not a D9-only change.

kim.pepper’s picture

Status: Needs review » Reviewed & tested by the community

Lgtm

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 3ccf26469e to 9.0.x and 31dfdce5ca to 8.9.x and d37edf9f12 to 8.8.x. Thanks!

Backported to 8.8.x as this code was only added in 8.8.x so let's never release a Drupal with this mistake...

  • alexpott committed 3ccf264 on 9.0.x
    Issue #3087514 by plach, kim.pepper: Remove unused RequestStack property...

  • alexpott committed 31dfdce on 8.9.x
    Issue #3087514 by plach, kim.pepper: Remove unused RequestStack property...

  • alexpott committed d37edf9 on 8.8.x
    Issue #3087514 by plach, kim.pepper: Remove unused RequestStack property...
xjm’s picture

Version: 8.9.x-dev » 8.8.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.