With #2896815: Replace the order summary view with a Twig template we added a Twig template to handle displaying the checkout sidebar summary instead of a view display.

EXCEPT, we never removed the view value from the default config! 😱

    order_summary:
      view: commerce_checkout_order_summary
      step: _sidebar
      weight: 5

We need to set the view property to a null value. Probably by just removing it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

amjad1233’s picture

Assigned: Unassigned » amjad1233
amjad1233’s picture

Assigned: amjad1233 » Unassigned
Status: Active » Needs review
FileSize
575 bytes
bojanz’s picture

Status: Needs review » Needs work

#3 seems to have been generated by editing the YML file by hand, which produces output that doesn't match what would be if you edited the checkout flow and then re-exported config.

amjad1233’s picture

Assigned: Unassigned » amjad1233

Good pick. Cool I will do that. I apologise as I am new to contribution space.

amjad1233’s picture

Status: Needs work » Needs review
FileSize
593 bytes

@bojanz When I exported the config, It came with other stuff as well which I omitted thinking to match the default config of the module.

i.e., I removed

    completion_register:
      step: complete
      weight: 10
    payment_information:
      step: order_information
      weight: 10
    payment_process:
      capture: true
      step: payment
      weight: 10
    coupon_redemption:
      allow_multiple: false
      step: _sidebar
      weight: 10

Is that seems right ?

mglaman’s picture

I think it's OK to omit the other added config (the default config on install is just out of date in general.) This issue is about fixing an oversight from the initial issue.

What do you think, @bojanz?

I thought I saw an issue about general "refresh all of our existing configs", but I can't find it. And that wouldn't fix this issue.

  • bojanz committed eb10ed8 on 8.x-2.x authored by amjad1233
    Issue #3087512 by amjad1233: The Default checkout flow is still using a...
bojanz’s picture

Status: Needs review » Fixed

#6 looks good. Committed. Thanks!

We'll want to update the whole export in another issue. We've already re-exported a lot of our config in 2.14, but there's always more.

amjad1233’s picture

Cheers Guys thanks for that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.