Problem/Motivation
When @cboyden's team did an assistive tech walkthrough of Media Library for #2834729: [META] Roadmap to stabilize Media Library using NVDA on Firefox, we discovered that the words "remove" and "removed" sound too similar when a user is tabbing through and removing items from the list that has already been added.
This interaction can be viewed on the video recording of the September 29, 2019 walkthrough of Media Library at around minute 31.
Proposed resolution
Change the text announced after an item is removed so that the resulting text that is read will be more easily understood.
Before: "Removed Foo."
After: "Foo has been removed."
Remaining tasks
- DONE. Select the preferred text to announce and implement.
User interface changes
Updates an invisible string used by assistive technology.
API changes
None anticipated.
Data model changes
None anticipated.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-3087405-4-11.txt | 5.03 KB | andrewmacpherson |
#12 | 3087405-11.patch | 3.05 KB | andrewmacpherson |
Comments
Comment #2
phenaproximaQuick and easy patch. Let's see if this breaks tests, and how many.
Comment #4
bnjmnmThis patch fixes the tests
Comment #6
bnjmnmComment #7
phenaproximaLooks great! Tagging for accessibility review; I think an accessibility maintainer should be the one to sign-off/RTBC this.
Comment #8
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedThis looks fine. I haven't manually tested it, but it's just a string change.
The new string is a little bit more verbose, but is still everyday English. It doesn't try any spelling or punctuation hacks which would be weird in Braille.
The confusion between "remove" and "removed" is an interesting one. It could be more or less of a problem depending on which text-to-speech engine (or voice, even) is used with the screen reader.
Comment #9
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #10
alexpottNeeds a reroll.
Comment #11
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #12
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedRe-roll.
Comment #13
phenaproximaInterdiff is confusing, but the actual patch looks good to me. RTBC once tests pass. Thanks, @andrewmacpherson!
Comment #15
alexpottCrediting @cboyden and @rainbreaw
Comment #17
alexpottCrediting @annagaz - trying to credit everyone from the video.
Comment #18
alexpottCommitted and pushed a2f5778f56 to 9.0.x and 4a7d1dde4c to 8.9.x. Thanks!
Going to ask other committers about backporting this to 8.8.x
Comment #21
alexpottDiscussed with @catch who +1'd the backport.