Problem/Motivation

When @cboyden's team did an assistive tech walkthrough of Media Library for #2834729: [META] Roadmap to stabilize Media Library using NVDA on Firefox, we discovered that the words "remove" and "removed" sound too similar when a user is tabbing through and removing items from the list that has already been added.

This interaction can be viewed on the video recording of the September 29, 2019 walkthrough of Media Library at around minute 31.

Proposed resolution

Change the text announced after an item is removed so that the resulting text that is read will be more easily understood.

Before: "Removed Foo."
After: "Foo has been removed."

Remaining tasks

  • DONE. Select the preferred text to announce and implement.

User interface changes

Updates an invisible string used by assistive technology.

API changes

None anticipated.

Data model changes

None anticipated.

CommentFileSizeAuthor
#12 interdiff-3087405-4-11.txt5.03 KBandrewmacpherson
#12 3087405-11.patch3.05 KBandrewmacpherson
#4 3087405-4.patch3.02 KBbnjmnm
#4 interdiff_2-4.txt2.12 KBbnjmnm
#2 3087405-2.patch919 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rainbreaw created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
3087405-2.patch919 bytes

Quick and easy patch. Let's see if this breaks tests, and how many.

Status: Needs review » Needs work

The last submitted patch, 2: 3087405-2.patch, failed testing. View results

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Status: Needs work » Needs review
FileSize
interdiff_2-4.txt2.12 KB
3087405-4.patch3.02 KB

This patch fixes the tests

Status: Needs review » Needs work

The last submitted patch, 4: 3087405-4.patch, failed testing. View results

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: +Needs accessibility review

Looks great! Tagging for accessibility review; I think an accessibility maintainer should be the one to sign-off/RTBC this.

andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented
Issue summary: View changes
Issue tags: -Needs accessibility review

This looks fine. I haven't manually tested it, but it's just a string change.
The new string is a little bit more verbose, but is still everyday English. It doesn't try any spelling or punctuation hacks which would be weird in Braille.

The confusion between "remove" and "removed" is an interesting one. It could be more or less of a problem depending on which text-to-speech engine (or voice, even) is used with the screen reader.

andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll.

andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented
Assigned: Unassigned » andrewmacpherson
andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented
Assigned: andrewmacpherson » Unassigned
Status: Needs work » Needs review
FileSize
3087405-11.patch3.05 KB
interdiff-3087405-4-11.txt5.03 KB

Re-roll.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Interdiff is confusing, but the actual patch looks good to me. RTBC once tests pass. Thanks, @andrewmacpherson!

alexpott credited cboyden.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Crediting @cboyden and @rainbreaw

alexpott credited annagaz.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Crediting @annagaz - trying to credit everyone from the video.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed a2f5778f56 to 9.0.x and 4a7d1dde4c to 8.9.x. Thanks!

Going to ask other committers about backporting this to 8.8.x

  • alexpott committed a2f5778 on 9.0.x 
    Issue #3087405 by andrewmacpherson, bnjmnm, phenaproxima, rainbreaw,...

  • alexpott committed 4a7d1dd on 8.9.x 
    Issue #3087405 by andrewmacpherson, bnjmnm, phenaproxima, rainbreaw,...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Patch (to be ported) » Fixed

Discussed with @catch who +1'd the backport.

  • alexpott committed 53027d7 on 8.8.x 
    Issue #3087405 by andrewmacpherson, bnjmnm, phenaproxima, rainbreaw,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.