This would help debugging a lot.ca362ad2bc6d005e288b2493077f140e315a862a

CommentFileSizeAuthor
#2 blazy-3084187-2-Add-option-to-serve-un-minified-JS.patch2.7 KBgeek-merlin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geek.merlin aka axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
FileSize
blazy-3084187-2-Add-option-to-serve-un-minified-JS.patch2.7 KB

Here's my temporary patch of .libraries.yml. I'd say we can do this and rely on core or advagg minification, but YMMV.

gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Active » Postponed (maintainer needs more info)

I know a bit weird, but I never use AdvAgg, that is why all my modules' JS files are minified. Perhaps someday I should use it, anyway :)

Until then, perhaps modifying with hook_library_info_alter is the way to go, given a new option such as Disable JS minification? is enabled under Blazy UI settings?

Other reason is even with JS minified enabled I could still debug issues at Chrome Dev tool where you are still given unminified JS versions.

However if your approach is making your life easier, I have no other objections.
If you commit it, please also delete the no-longer in-use minified JS files.

Feel free to commit it on your discretion. Thanks!

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Needs work

OK so i'm going to do some more needed changes and commit this. (I know that chrome feature but it does not help un-obfuscate variable names ;-)

Leaving open to amend this if something unexpectedly breaks.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Title: Add option to serve un-minified JS » Serve un-minified JS
geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Status: Needs work » Fixed

OK, automatic ans manual tests pass.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.