Problem/Motivation

This is a bug fix for #2994702: Allow editors to alter embed-specific metadata, as well as `data-align` and `data-caption`

Using EditorMediaDialog to change alignment can leads to double alignment classes on the wrapper. This is due to the fact that the alignment classes are not cleared when the dialog is saved.

double alignment classes

Proposed resolution

Since there are three classes, we need to maintain, we can just clear the classes before adding a new class.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 double align classes.png62.16 KBoknate
#2 3081983-2.patch4.46 KBoknate
#2 3081983-2--FAIL.patch1.58 KBoknate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
3081983-2--FAIL.patch1.58 KB
3081983-2.patch4.46 KB

Here's the fix, plus a FAIL patch that demonstrates the bug.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
Status: Active » Needs review
FileSize
double align classes.png62.16 KB
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
Related issues: +#2994702: Allow editors to alter embed-specific metadata, as well as `data-align` and `data-caption`

The last submitted patch, 2: 3081983-2--FAIL.patch, failed testing. View results

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue tags: +Media Initiative
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Nice catch, solid test coverage, trivial fix. 👍🚢

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented

Crediting @Wim Leers for review.

  • effulgentsia committed 0df5ad9 on 8.8.x 
    Issue #3081983 by oknate, Wim Leers: Double Alignment classes on widget...
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Reviewed & tested by the community » Fixed

Pushed to 8.8.x.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate commented

Thanks! This was a nice surprise on a Saturday night!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.