cURL 7.18.2 and SimpleTest module bitterly despise one another [#308186]

Tests under the newest release of MAMP (1.7.2) fail absolutely spectacularly.

For example, the Aggregator group of tests ends up with 132 passes, 131 fails, 36 exceptions.

In contrast, others in #drupal with cURL 7.16.xx had 0 failures.

I traced this with some tedious error_log()ing to the curlExec() function in drupal_web_test_case.php, which doesn't appear to be able to POST values at all. Dumping $this->_content directly after $this->drupalSetContent(curl_exec($this->ch), curl_getinfo($this->ch, CURLINFO_EFFECTIVE_URL)); merely spits back the same form, rather than the page one would expect once the form values were submitted.

Um. Help? Not being able to run tests kind of puts a damper on the whole committing patches thing. ;P

Comment	File	Size	Author
#3	somebody.patch	825 bytes	chx
#3
#2	simpletest-fix-curl-errors-308186-2.patch	1.16 KB	webchick
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lyricnz CreditAttribution: lyricnz commented 14 September 2008 at 04:30

I can confirm this behaviour (MAMP 1.7.2). It looks like it's literally doing GET requests, rather than POST requests. Here's the Apache access_log for aggregator.test:

::1 - - [14/Sep/2008:14:25:57 +1000] "POST /drupal/admin/build/testing HTTP/1.1" 302 -
::1 - - [14/Sep/2008:14:25:57 +1000] "GET /drupal/batch?op=start&id=5 HTTP/1.1" 200 3597
::1 - - [14/Sep/2008:14:25:58 +1000] "GET /drupal/misc/progress.js?1221366357 HTTP/1.1" 200 3042
::1 - - [14/Sep/2008:14:25:58 +1000] "GET /drupal/misc/batch.js?1221366357 HTTP/1.1" 200 1215
::1 - - [14/Sep/2008:14:26:01 +1000] "GET /drupal HTTP/1.1" 301 328
::1 - - [14/Sep/2008:14:26:01 +1000] "GET /drupal/ HTTP/1.1" 200 5791
::1 - - [14/Sep/2008:14:26:01 +1000] "GET /drupal/user HTTP/1.1" 200 4262
::1 - - [14/Sep/2008:14:26:02 +1000] "GET /drupal/user HTTP/1.1" 200 4262
::1 - - [14/Sep/2008:14:26:02 +1000] "GET /drupal/admin/content/aggregator/add/feed HTTP/1.1" 403 4460
::1 - - [14/Sep/2008:14:26:02 +1000] "GET /drupal/aggregator/sources/ HTTP/1.1" 403 4333
::1 - - [14/Sep/2008:14:26:02 +1000] "GET /drupal/admin/content/aggregator/edit/feed/ HTTP/1.1" 403 4462
::1 - - [14/Sep/2008:14:25:58 +1000] "POST /drupal/batch?id=5&op=do HTTP/1.1" 200 360
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal HTTP/1.1" 301 328
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal/ HTTP/1.1" 200 5791
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal/user HTTP/1.1" 200 4262
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal/user HTTP/1.1" 200 4262
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal/admin/content/aggregator/add/feed HTTP/1.1" 403 4460
::1 - - [14/Sep/2008:14:26:06 +1000] "GET /drupal/admin/content/aggregator/edit/feed/ HTTP/1.1" 403 4462
::1 - - [14/Sep/2008:14:26:07 +1000] "GET /drupal/aggregator/sources/ HTTP/1.1" 403 4333
::1 - - [14/Sep/2008:14:26:07 +1000] "GET /drupal/admin/content/aggregator/edit/feed/ HTTP/1.1" 403 4462
::1 - - [14/Sep/2008:14:26:02 +1000] "POST /drupal/batch?id=5&op=do HTTP/1.1" 200 507

Whereas it used to look more like this:

::1 - - [14/Sep/2008:13:19:46 +1000] "POST /drupal/admin/build/testing HTTP/1.1" 302 -
::1 - - [14/Sep/2008:13:19:47 +1000] "GET /drupal/batch?op=start&id=5 HTTP/1.1" 200 3597
::1 - - [14/Sep/2008:13:19:47 +1000] "GET /drupal/misc/progress.js?1221362387 HTTP/1.1" 200 3042
::1 - - [14/Sep/2008:13:19:47 +1000] "GET /drupal/misc/batch.js?1221362387 HTTP/1.1" 200 1215
::1 - - [14/Sep/2008:13:19:47 +1000] "GET /drupal/misc/progress.gif HTTP/1.1" 200 790
::1 - - [14/Sep/2008:13:19:52 +1000] "GET /drupal HTTP/1.1" 301 321
::1 - - [14/Sep/2008:13:19:52 +1000] "GET /drupal/ HTTP/1.1" 200 5686
::1 - - [14/Sep/2008:13:19:53 +1000] "GET /drupal/user HTTP/1.1" 200 4157
::1 - - [14/Sep/2008:13:19:53 +1000] "POST /drupal/user HTTP/1.1" 302 -
::1 - - [14/Sep/2008:13:19:53 +1000] "GET /drupal/user/4 HTTP/1.1" 200 3550
::1 - - [14/Sep/2008:13:19:54 +1000] "GET /drupal/logout HTTP/1.1" 302 -
::1 - - [14/Sep/2008:13:19:54 +1000] "GET /drupal/ HTTP/1.1" 200 4781
::1 - - [14/Sep/2008:13:19:54 +1000] "GET /drupal/user HTTP/1.1" 200 4157
::1 - - [14/Sep/2008:13:19:54 +1000] "GET /drupal/user HTTP/1.1" 200 4157
::1 - - [14/Sep/2008:13:19:55 +1000] "POST /drupal/user HTTP/1.1" 302 -
::1 - - [14/Sep/2008:13:19:55 +1000] "GET /drupal/user/3 HTTP/1.1" 200 3477
::1 - - [14/Sep/2008:13:19:55 +1000] "GET /drupal/logout HTTP/1.1" 302 -
::1 - - [14/Sep/2008:13:19:55 +1000] "GET /drupal/ HTTP/1.1" 200 4781
::1 - - [14/Sep/2008:13:19:55 +1000] "GET /drupal/user HTTP/1.1" 200 4157
::1 - - [14/Sep/2008:13:19:56 +1000] "GET /drupal/user HTTP/1.1" 200 4157

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 14 September 2008 at 06:06

Status:

Active

» Needs review

File	Size
simpletest-fix-curl-errors-308186-2.patch	1.16 KB

After several minutes of troubleshooting, chx suggested removing this bit, and suddenly everything works.

Needs to be tested by someone NOT on this screwy version of MAMP. ;)

Comment #3

chx CreditAttribution: chx commented 14 September 2008 at 06:19

File	Size
somebody.patch	825 bytes

tested, works. I can not understand what happens really here but works for now.

Comment #4

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 14 September 2008 at 06:24

To clarify, chx's patch reverts this line back to the way it was before #231190: Page Cache doesn't work with HEAD requests landed.

Comment #5

lyricnz CreditAttribution: lyricnz commented 14 September 2008 at 06:38

Status:

Needs review

» Reviewed & tested by the community

I've tried this a couple of times to be sure, and the patch in #2 works for me, while the patch in #3 produces the same errors as the unpatched head. Given that, I'll RTBC the patch in comment #2 (webchick)

Comment #6

lyricnz CreditAttribution: lyricnz commented 14 September 2008 at 06:44

Patch also works on older version of MAMP (1.7.1)

Comment #7

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 14 September 2008 at 06:46

Status:

Reviewed & tested by the community

» Fixed

Committed. Thanks for awesome debug session, folks! :D

Comment #8

c960657 CreditAttribution: c960657 commented 17 September 2008 at 19:16

After revision 1.39 of modules/simpletest/drupal_web_test_case.php was checked in, I get 1 failed test in the Tracker module:

Message:    New comments are counted on the tracker listing pages. 
Group:      Other
Filename:   tracker.test
Line:       140
Function:   TrackerTest->testTrackerNewComments()

Comment #9

c960657 CreditAttribution: c960657 commented 17 September 2008 at 19:25

Hmm, it looks as if the test just sometimes fails, i.e. it is probably not related to this issue. Please ignore comment #8.

Comment #10

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 17 September 2008 at 19:27

Hey, c960657, could you hop into #drupal IRC sometime? The entire test suite is passing okay here, and it's easier for us to debug test failures in real time than over the issue queue.