Attaching the Stripe javascript directly to $page doesn't work, see https://drupal.stackexchange.com/questions/172112/why-does-pagecontentat...

In hook_page_build() we should attach to $page['content'] instead. Perhaps this depends on the theme implementation, but by default the current version of this module doesn't work at all - this is probably a result of something from https://www.drupal.org/project/commerce_stripe_pi/issues/3077684 but I don't really know what order things have been changed in.

Comments

premium-ben created an issue. See original summary.

GoZ’s picture

GoZ CreditAttribution: GoZ commented

I broke something here you are right. My bad.

I fix it + also use attachment instead of drupal_add_js in another function

Thanks for the report

  • GoZ committed a6f7cc0 on 7.x-1.x 
    Issue #3080082: Stripe JS not being attached to page
GoZ’s picture

GoZ CreditAttribution: GoZ commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.