Return type for function drupal_static is declared as array, while it returns $default_value which can actually be of mixed type (NULL, bool, objects, etc), when static variable is not yet present.
Due to this incorrect return type declaration, static code analysis tools give false positives.

CommentFileSizeAuthor
#2 3078839-incorrect-return-type-declaration-for-function-drupal_static.patch523 bytesjustas.raudonius
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

justas.raudonius created an issue. See original summary.

justas.raudonius’s picture

justas.raudonius CreditAttribution: justas.raudonius commented
FileSize
3078839-incorrect-return-type-declaration-for-function-drupal_static.patch523 bytes
Eric_A’s picture

Eric_A CreditAttribution: Eric_A at Dutch Open Projects commented
Status: Active » Reviewed & tested by the community

Yeah, a returned $default_value could be anything.

For $my_static = &drupal_static(__FUNCTION__); PHPStan currently barks: "Variable $my_static in isset() always exists and is not nullable."

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed b90bd58 and pushed to 8.8.x. Thanks!

  • larowlan committed b90bd58 on 8.8.x 
    Issue #3078839 by justas.raudonius: Incorrect return type declaration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.