View titles in breadcrumb don't get properly translated

The core patch from #2716019-67: View titles in breadcrumb don't get properly translated returns the title as a \Drupal\Core\Render\Markup object, which needs to be accounted for in \Drupal\easy_breadcrumb\EasyBreadcrumbBuilder::getTitleString().

Patch attached. Note that the core patch needs to be applied as well. Patch includes a simple update to the kernel tests, but does not include test for the title being correctly displayed in the correct language.

Thanks!

I started working on issue review.

I have tested it with latest Drupal 8.7.6 and it is working. Note that it was not even working with default language, not just with translation!

Shouldn't we cover other cases in tests too then? I'm fine with marking it RTBC now, but maybe a follow-up issue would be beneficial.

#2 doesn't work with newest core patch 2716019 - View titles in breadcrumb don't get properly translated - #77 because title was changed from \Drupal\Core\Render\Markup to Drupal\views\Render\ViewsRenderPipelineMarkup

Hi folks, it seems that #13186043 changed direction. Here is a patch which should work more flexible regarding Markup classes. Credit (if issue is closed) should go to wrany as well, who contributed patch in some invisible comment.

// If title is object then try to render it.
+    if (is_object($title)) {
+      $titleClass = get_class($title);
+      if (in_array('render', get_class_methods($titleClass))) {
+        $title = $title->render();
+      }
+      else {
+        $title = (string) $title;
+      }
+      $title = strip_tags($title);
     }

I think that just checking for instances of MarkupInterface and converting to string should do what's required. The render() method gets invoked when converting TranslatableMarkup to string anyway, so it doesn't need to be called directly.

if ($title instanceof \Drupal\Component\Render\MarkupInterface) {
  $title = strip_tags((string) $title);
}

Thanks for review. Could you please point out where typecasting to string calls render function? I'm unable to find it. __toString function from FormattableMarkup is calling simpler code than render function.

\Drupal\Core\StringTranslation\TranslatableMarkup uses \Drupal\Component\Utility\ToStringTrait, and it's there.

I don't think the other core MarkupInterface classes use render().

Simplified patch from #11.

If I understood the problem correctly it looks like it works. But I will leave this open so that others can test and confirm if it works like it should.
Regards!

In patch 14, the FormattableMarkup import and ViewsRenderPipelineMarkup import should be removed. On the other hand, I am attaching the patch for the current version (8.x-1.12). I know this is not the normal procedure, but I needed a patch and I attach it in case anyone finds it useful.

Thanks Folks!

Hrm, after adding this fix, the tests are now failing in the dev branch. Anyone have any ideas? :)

https://www.drupal.org/pift-ci-job/1711952