Problem/Motivation

The DvG status screen currently has no option to alter status messages. Therefore if any dvg contrib or custom code wants to alter any of the messages, this is currently not possible.

Also the submodule dvg_payment_webform currently adds it's status message to the core's status page, which isn't consistent with other dvg (sub)modules. Also it's marked as error if no default payment provider is selected. If for example in a multi-domain setup, a domain doesn't have any payment provider enabled, this still still shows as an error.

Proposed resolution

  • Create hook_dvg_requirements_alter() to modify statuses on the DvG Status page.
  • Move the dvg_payment_webform status message to the DvG Status page and set the sevirity to Warning instead of Error
CommentFileSizeAuthor
#3 interdiff-2-3.txt985 bytespaulvandenburg
#3 dvg-dvg_status_page_altering-3071964-3.patch5.5 KBpaulvandenburg
#2 dvg-dvg_status_page_altering-3071964-2.patch5.51 KBtvoesenek

Comments

TVoesenek created an issue. See original summary.

tvoesenek’s picture

tvoesenek commented
Status: Active » Needs review
StatusFileSize
new dvg-dvg_status_page_altering-3071964-2.patch5.51 KB

This patch does the following:

  • Add a new hook_dvg_requirements_alter().
  • Add api documentation for hook_dvg_requirements() and hook_dvg_requirements_alter().
  • Move dvg_payment_webform requirements to the DvG status report and change the severity of the message from REQUIREMENTS_ERROR to REQUIREMENTS_WARNING
paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new dvg-dvg_status_page_altering-3071964-3.patch5.5 KB
new interdiff-2-3.txt985 bytes

Looks good.
However a short array syntax was used in the new alter hook api docs. For consistency we should convert that to the old style.

I've also updated the message for the hook_dvg_requirements to make it more specific that the DvG status page is for DvG related statuses.

tvoesenek’s picture

tvoesenek commented
Status: Needs review » Reviewed & tested by the community

I agree, looks good to me.

  • paulvandenburg committed 3a0926c on 7.x-1.x 
    Issue #3071964 by paulvandenburg, TVoesenek: Add hook to alter the DvG...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.