Used deprecated methods file_prepare_directory() in line 54 of /src/Tests/TokenUserTest.php and file_unmanaged_copy() in line 130, 131 of src/Tests/TokenFieldUiTest.php.

CommentFileSizeAuthor
#15 3070012-15.patch1.8 KBBerdir
#10 3070012-10.patch3.02 KBravi.shankar
#8 3070012-8.patch3.43 KBravi.shankar
#6 3070012-6.patch2.75 KBravi.shankar
#4 3070012-4.patch1.89 KBravi.shankar
#2 3070012-2.patch1.89 KBravi.shankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ravi.shankar created an issue. See original summary.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Active » Needs review
FileSize
3070012-2.patch1.89 KB

This patch will fix.

Status: Needs review » Needs work

The last submitted patch, 2: 3070012-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3070012-4.patch1.89 KB

This patch will fix.

Status: Needs review » Needs work

The last submitted patch, 4: 3070012-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3070012-6.patch2.75 KB

This will fix.

Status: Needs review » Needs work

The last submitted patch, 6: 3070012-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3070012-8.patch3.43 KB

This patch will fix.

Status: Needs review » Needs work

The last submitted patch, 8: 3070012-8.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3070012-10.patch3.02 KB

This will work.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Postponed

Not going to commit 8.7 deprecations as long as Drupal 8.6 is still supported.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Title: Used deprecated methods file_prepare_directory() and file_unmanaged_copy(). » [8.7+] Used deprecated methods file_prepare_directory() and file_unmanaged_copy().
idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Postponed » Needs review

Drupal 8.8.0 has been released. This means the 8.6.x branch is no longer supported and this issue is no longer postponed.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Needs review » Needs work 
+++ b/src/Tests/TokenFieldUiTest.php
@@ -100,6 +100,9 @@ class TokenFieldUiTest extends TokenTestBase {
+  /**
+   *
+   */

@@ -112,6 +115,9 @@ class TokenFieldUiTest extends TokenTestBase {
+  /**
+   *
+   */

@@ -193,7 +200,7 @@ class TokenFieldUiTest extends TokenTestBase {
+      // field_image.

@@ -215,7 +222,7 @@ class TokenFieldUiTest extends TokenTestBase {
+      // field_image_2.

+++ b/src/Tests/TokenUserTest.php
@@ -124,4 +124,5 @@ class TokenUserTest extends TokenTestBase {
+

Let's remove these unrelated changes from the patch so we don't introduce any more changed than necessary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
3070012-15.patch1.8 KB

Rerolled.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: [8.7+] Used deprecated methods file_prepare_directory() and file_unmanaged_copy(). » Used deprecated methods file_prepare_directory() and file_unmanaged_copy().

  • Berdir committed 3df1293 on 8.x-1.x 
    Issue #3070012 by ravi.shankar, Berdir: Used deprecated methods...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.