I get the following errors when viewing log entries that have a comment_notify log entry in them:

    * warning: Invalid argument supplied for foreach() in /home/.katona/davereid20/drupal-6/includes/common.inc on line 789.
    * warning: strtr() [function.strtr]: The second argument is not an array in /home/.katona/davereid20/drupal-6/includes/common.inc on line 806.

The offending line of code:

watchdog('comment_notify', $watchdog_message,
        WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));

Should be in the form of watchdog($type, $message, $variables = array(), $severity = WATCHDOG_NOTICE, $link = NULL) (D6 watchdog)

watchdog('comment_notify', $watchdog_message, array(), WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

Status: Active » Needs review
FileSize
1.39 KB

I think that fixes the error but not the underlying problem which was an old style watchdog message that wouldn't be translatable.

The attached patch fixes that (I believe).

Can you confirm that it fixes the errors you see?

greggles’s picture

Whoops that had a parse error.

Dave Reid’s picture

Checking now.

Dave Reid’s picture

Status: Needs review » Reviewed & tested by the community

Fixed. Now I need to figure out why I'm also having this same issue: #299548: Line breaks not showing up in email.

greggles’s picture

Status: Reviewed & tested by the community » Fixed

Great, fixed - http://drupal.org/cvs?commit=139464

Thanks, Dave Reid!

Dave Reid’s picture

Thanks very much greggles? Any word on #299548: Line breaks not showing up in email?
Edit: link fixed

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.